This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 1dd1d0b HDDS-4190. Intermittent failure in
TestOMVolumeSetOwnerRequest and TestOMVolumeSetQuotaRequest. (#2982)
1dd1d0b is described below
commit 1dd1d0ba399c7e6aceade646cb2cfc48035715ce
Author: Jyotinder Singh <[email protected]>
AuthorDate: Sun Jan 16 18:29:26 2022 +0530
HDDS-4190. Intermittent failure in TestOMVolumeSetOwnerRequest and
TestOMVolumeSetQuotaRequest. (#2982)
---
.../ozone/om/request/volume/TestOMVolumeSetOwnerRequest.java | 7 ++++++-
.../ozone/om/request/volume/TestOMVolumeSetQuotaRequest.java | 7 ++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git
a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetOwnerRequest.java
b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetOwnerRequest.java
index 9cd04f6..e771300 100644
---
a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetOwnerRequest.java
+++
b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetOwnerRequest.java
@@ -98,7 +98,12 @@ public class TestOMVolumeSetOwnerRequest extends
TestOMVolumeRequest {
.get(volumeKey).getCreationTime();
long modificationTime = omMetadataManager.getVolumeTable()
.get(volumeKey).getModificationTime();
- Assert.assertTrue(modificationTime > creationTime);
+
+ // creationTime and modificationTime can be the same to the precision of a
+ // millisecond - since there is no time-consuming operation between
+ // TestOMRequestUtils.addVolumeToDB (sets creationTime) and
+ // preExecute (sets modificationTime).
+ Assert.assertTrue(modificationTime >= creationTime);
OzoneManagerStorageProtos.PersistedUserVolumeInfo newOwnerVolumeList =
omMetadataManager.getUserTable().get(newOwnerKey);
diff --git
a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetQuotaRequest.java
b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetQuotaRequest.java
index 3d63ae5..2458ef7 100644
---
a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetQuotaRequest.java
+++
b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/volume/TestOMVolumeSetQuotaRequest.java
@@ -108,7 +108,12 @@ public class TestOMVolumeSetQuotaRequest extends
TestOMVolumeRequest {
.getVolumeTable().get(volumeKey).getCreationTime();
long modificationTime = omMetadataManager
.getVolumeTable().get(volumeKey).getModificationTime();
- Assert.assertTrue(modificationTime > creationTime);
+
+ // creationTime and modificationTime can be the same to the precision of a
+ // millisecond - since there is no time-consuming operation between
+ // TestOMRequestUtils.addVolumeToDB (sets creationTime) and
+ // preExecute (sets modificationTime).
+ Assert.assertTrue(modificationTime >= creationTime);
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
