This is an automated email from the ASF dual-hosted git repository.

adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 13a284834b HDDS-7944. Add dash-separated-options where missing (#3943)
13a284834b is described below

commit 13a284834b12a5bfc458378dee786b931d4939cf
Author: Navink <[email protected]>
AuthorDate: Fri Feb 10 18:16:25 2023 +0530

    HDDS-7944. Add dash-separated-options where missing (#3943)
---
 .../hdds/scm/cli/ContainerBalancerStartSubcommand.java       | 12 ++++++++----
 .../hadoop/ozone/admin/om/DecommissionOMSubcommand.java      |  2 +-
 .../main/java/org/apache/hadoop/ozone/debug/DBScanner.java   |  2 +-
 .../main/java/org/apache/hadoop/ozone/debug/DropTable.java   |  2 +-
 .../apache/hadoop/ozone/freon/SCMThroughputBenchmark.java    |  2 +-
 5 files changed, 12 insertions(+), 8 deletions(-)

diff --git 
a/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
 
b/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
index 7b349d1426..d81e971dec 100644
--- 
a/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
+++ 
b/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
@@ -47,24 +47,28 @@ public class ContainerBalancerStartSubcommand extends 
ScmSubcommand {
           " balancer will run for.")
   private Optional<Integer> iterations;
 
-  @Option(names = {"-d", "--maxDatanodesPercentageToInvolvePerIteration"},
+  @Option(names = {"-d", "--max-datanodes-percentage-to-involve-per-iteration",
+      "--maxDatanodesPercentageToInvolvePerIteration"},
       description = "Max percentage of healthy, in service datanodes " +
           "that can be involved in balancing in one iteration (for example, " +
           "'20' for 20%%).")
   private Optional<Integer> maxDatanodesPercentageToInvolvePerIteration;
 
-  @Option(names = {"-s", "--maxSizeToMovePerIterationInGB"},
+  @Option(names = {"-s", "--max-size-to-move-per-iteration-in-gb",
+      "--maxSizeToMovePerIterationInGB"},
       description = "Maximum size that can be moved per iteration of " +
           "balancing (for example, '500' for 500GB).")
   private Optional<Long> maxSizeToMovePerIterationInGB;
 
-  @Option(names = {"-e", "--maxSizeEnteringTargetInGB"},
+  @Option(names = {"-e", "--max-size-entering-target-in-gb",
+      "--maxSizeEnteringTargetInGB"},
       description = "Maximum size that can enter a target datanode while " +
           "balancing. This is the sum of data from multiple sources (for " +
           "example, '26' for 26GB).")
   private Optional<Long> maxSizeEnteringTargetInGB;
 
-  @Option(names = {"-l", "--maxSizeLeavingSourceInGB"},
+  @Option(names = {"-l", "--max-size-leaving-source-in-gb",
+      "--maxSizeLeavingSourceInGB"},
       description = "Maximum size that can leave a source datanode while " +
           "balancing. This is the sum of data moving to multiple targets " +
           "(for example, '26' for 26GB).")
diff --git 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/DecommissionOMSubcommand.java
 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/DecommissionOMSubcommand.java
index 455b3ca9d6..8d01b15d00 100644
--- 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/DecommissionOMSubcommand.java
+++ 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/DecommissionOMSubcommand.java
@@ -71,7 +71,7 @@ public class DecommissionOMSubcommand implements 
Callable<Void> {
       required = true)
   private String omServiceId;
 
-  @CommandLine.Option(names = {"-nodeid"},
+  @CommandLine.Option(names = {"-nodeid", "--nodeid"},
       description = "NodeID of the OM to be decommissioned.",
       required = true)
   private String decommNodeId;
diff --git 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
index a45648ce2b..9e4c25641e 100644
--- 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
+++ 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java
@@ -70,7 +70,7 @@ public class DBScanner implements Callable<Void>, 
SubcommandWithParent {
   public static final Logger LOG =
       LoggerFactory.getLogger(DBScanner.class);
 
-  @CommandLine.Option(names = {"--column_family"},
+  @CommandLine.Option(names = {"--column_family", "--column-family"},
       required = true,
       description = "Table name")
   private String tableName;
diff --git 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java
index 5bf619e098..745712850b 100644
--- 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java
+++ 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java
@@ -39,7 +39,7 @@ import java.util.concurrent.Callable;
 )
 public class DropTable implements Callable<Void>, SubcommandWithParent {
 
-  @CommandLine.Option(names = {"--column_family"},
+  @CommandLine.Option(names = {"--column-family", "--column_family"},
       description = "Table name")
   private String tableName;
 
diff --git 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SCMThroughputBenchmark.java
 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SCMThroughputBenchmark.java
index 4fe7d4af97..8704584ca7 100644
--- 
a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SCMThroughputBenchmark.java
+++ 
b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SCMThroughputBenchmark.java
@@ -163,7 +163,7 @@ public final class SCMThroughputBenchmark implements 
Callable<Void> {
       defaultValue = "4")
   private int numHeartbeats = 4;
 
-  @CommandLine.Option(names = {"--scmHost"},
+  @CommandLine.Option(names = {"--scmHost", "--scm-host"},
       required = true,
       description = "The leader scm host x.x.x.x.")
   private String scm;


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to