This is an automated email from the ASF dual-hosted git repository.
sammichen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new b852395e2a HDDS-8070. DBCheckpointMetrics is not unregistered during
OM stop. (#4338)
b852395e2a is described below
commit b852395e2a44fbbf5102b3b9aa8b3ae1bcffecf4
Author: Sammi Chen <[email protected]>
AuthorDate: Fri Mar 3 11:24:23 2023 +0800
HDDS-8070. DBCheckpointMetrics is not unregistered during OM stop. (#4338)
---
.../main/java/org/apache/hadoop/hdds/utils/DBCheckpointMetrics.java | 5 +++++
.../src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java | 3 +++
2 files changed, 8 insertions(+)
diff --git
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointMetrics.java
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointMetrics.java
index 3dc176644d..d3f3cd1d8f 100644
---
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointMetrics.java
+++
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointMetrics.java
@@ -53,6 +53,11 @@ public class DBCheckpointMetrics {
new DBCheckpointMetrics());
}
+ public void unRegister() {
+ MetricsSystem ms = DefaultMetricsSystem.instance();
+ ms.unregisterSource(SOURCE_NAME);
+ }
+
@VisibleForTesting
public void setLastCheckpointCreationTimeTaken(long val) {
this.lastCheckpointCreationTimeTaken.set(val);
diff --git
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
index d194360130..faeaae6885 100644
---
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
+++
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
@@ -1309,6 +1309,9 @@ public class OMMetrics implements OmMetadataReaderMetrics
{
}
public void unRegister() {
+ if (dbCheckpointMetrics != null) {
+ dbCheckpointMetrics.unRegister();
+ }
MetricsSystem ms = DefaultMetricsSystem.instance();
ms.unregisterSource(SOURCE_NAME);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
