This is an automated email from the ASF dual-hosted git repository.

adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 601fadf9ee HDDS-8898. Replication limit should not be less than 
reconstruction weight (#4954)
601fadf9ee is described below

commit 601fadf9ee8f6579e88f6e753e82dcabd2e006cb
Author: Doroszlai, Attila <[email protected]>
AuthorDate: Thu Jun 22 18:44:49 2023 +0200

    HDDS-8898. Replication limit should not be less than reconstruction weight 
(#4954)
---
 .../hdds/scm/container/replication/ReplicationManager.java     | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git 
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
 
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
index 14a325b844..72f5b9eb47 100644
--- 
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
+++ 
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
@@ -1333,8 +1333,14 @@ public class ReplicationManager implements SCMService {
             + " event.timeout, which is set to " + eventTimeout);
       }
       if (reconstructionCommandWeight <= 0) {
-        throw new IllegalArgumentException("reconstructionCommandWeight is"
-            + " set to " + reconstructionCommandWeight + " and must be > 0");
+        throw new IllegalArgumentException("datanode.reconstruction.weight: "
+            + reconstructionCommandWeight + " must be > 0");
+      }
+      if (datanodeReplicationLimit < reconstructionCommandWeight) {
+        throw new IllegalArgumentException("datanode.replication.limit: "
+            + datanodeReplicationLimit
+            + " must be >= datanode.reconstruction.weight: "
+            + reconstructionCommandWeight);
       }
       if (inflightReplicationLimitFactor < 0) {
         throw new IllegalArgumentException(


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to