This is an automated email from the ASF dual-hosted git repository.

siddhant pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 9d1cfceb15 HDDS-9204. Reduce log level of PipelinePlacementPolicy 
failed to create pipeline message (#5211)
9d1cfceb15 is described below

commit 9d1cfceb155e4b5f1f78bff9bf839f37b3ae169e
Author: Stephen O'Donnell <[email protected]>
AuthorDate: Fri Aug 25 12:38:57 2023 +0100

    HDDS-9204. Reduce log level of PipelinePlacementPolicy failed to create 
pipeline message (#5211)
---
 .../hdds/scm/pipeline/PipelinePlacementPolicy.java       | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git 
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
 
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
index 7b52d6f220..0ec5abb419 100644
--- 
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
+++ 
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
@@ -163,7 +163,7 @@ public final class PipelinePlacementPolicy extends 
SCMCommonPlacementPolicy {
       msg = String.format("Pipeline creation failed due to no sufficient" +
               " healthy datanodes. Required %d. Found %d. Excluded %d.",
           nodesRequired, initialHealthyNodesCount, excludedNodesSize);
-      LOG.warn(msg);
+      LOG.debug(msg);
       throw new SCMException(msg,
           SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
     }
@@ -366,14 +366,14 @@ public final class PipelinePlacementPolicy extends 
SCMCommonPlacementPolicy {
             "pipeline allocation. healthyNodes size: %d, " +
             "excludeNodes size: %d", healthyNodes.size(),
             mutableExclude.size());
-        LOG.warn(msg);
+        LOG.debug(msg);
         throw new SCMException(msg,
             SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
       }
     }
 
     if (results.size() < nodesRequired) {
-      LOG.warn("Unable to find the required number of " +
+      LOG.debug("Unable to find the required number of " +
               "healthy nodes that  meet the criteria. Required nodes: {}, " +
               "Found nodes: {}", nodesRequired, results.size());
       throw new SCMException("Unable to find required number of nodes.",
@@ -413,13 +413,11 @@ public final class PipelinePlacementPolicy extends 
SCMCommonPlacementPolicy {
         removePeers(anchor, healthyNodes);
         mutableExclude.add(anchor);
       } else {
-        LOG.warn("Unable to find healthy node for anchor(first) node.");
+        LOG.debug("Unable to find healthy node for anchor(first) node.");
         throw new SCMException("Unable to find anchor node.",
             SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
       }
-      if (LOG.isDebugEnabled()) {
-        LOG.debug("First node chosen: {}", anchor);
-      }
+      LOG.debug("First node chosen: {}", anchor);
     } else if (usedNodes.size() == 1) {
       // Only 1 usedNode, consider it as anchor node.
       anchor = usedNodes.get(0);
@@ -457,9 +455,7 @@ public final class PipelinePlacementPolicy extends 
SCMCommonPlacementPolicy {
         results.add(nextNode);
         removePeers(nextNode, healthyNodes);
         mutableExclude.add(nextNode);
-        if (LOG.isDebugEnabled()) {
-          LOG.debug("Second node chosen: {}", nextNode);
-        }
+        LOG.debug("Second node chosen: {}", nextNode);
       } else {
         LOG.debug("Pipeline Placement: Unable to find 2nd node on different " +
             "rack based on rack awareness. anchor: {}", anchor);


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to