This is an automated email from the ASF dual-hosted git repository.

sodonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 58981fd5e1 HDDS-8648. Improving OmKeyInfo.Builder and 
OmDirectoryInfo.Builder usage (#5328)
58981fd5e1 is described below

commit 58981fd5e12a40441bf607520813ae98c6e6aefe
Author: VarshaRavi <[email protected]>
AuthorDate: Wed Sep 20 20:20:06 2023 +0530

    HDDS-8648. Improving OmKeyInfo.Builder and OmDirectoryInfo.Builder usage 
(#5328)
---
 .../ozone/om/request/file/OMFileRequest.java       | 54 +++++++++++-----------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git 
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
 
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
index 2e547b51eb..166bf376a9 100644
--- 
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
+++ 
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
@@ -706,23 +706,23 @@ public final class OMFileRequest {
   public static OmKeyInfo getOmKeyInfo(String volumeName, String bucketName,
       OmDirectoryInfo dirInfo, String keyName) {
 
-    OmKeyInfo.Builder builder = new OmKeyInfo.Builder();
-    builder.setParentObjectID(dirInfo.getParentObjectID());
-    builder.setKeyName(keyName);
-    builder.setAcls(dirInfo.getAcls());
-    builder.addAllMetadata(dirInfo.getMetadata());
-    builder.setVolumeName(volumeName);
-    builder.setBucketName(bucketName);
-    builder.setCreationTime(dirInfo.getCreationTime());
-    builder.setModificationTime(dirInfo.getModificationTime());
-    builder.setObjectID(dirInfo.getObjectID());
-    builder.setUpdateID(dirInfo.getUpdateID());
-    builder.setFileName(dirInfo.getName());
-    builder.setReplicationConfig(RatisReplicationConfig
-        .getInstance(HddsProtos.ReplicationFactor.ONE));
-    builder.setOmKeyLocationInfos(Collections.singletonList(
-            new OmKeyLocationInfoGroup(0, new ArrayList<>())));
-    return builder.build();
+    return new OmKeyInfo.Builder()
+        .setParentObjectID(dirInfo.getParentObjectID())
+        .setKeyName(keyName)
+        .setAcls(dirInfo.getAcls())
+        .addAllMetadata(dirInfo.getMetadata())
+        .setVolumeName(volumeName)
+        .setBucketName(bucketName)
+        .setCreationTime(dirInfo.getCreationTime())
+        .setModificationTime(dirInfo.getModificationTime())
+        .setObjectID(dirInfo.getObjectID())
+        .setUpdateID(dirInfo.getUpdateID())
+        .setFileName(dirInfo.getName())
+        .setReplicationConfig(RatisReplicationConfig
+            .getInstance(HddsProtos.ReplicationFactor.ONE))
+        .setOmKeyLocationInfos(Collections.singletonList(
+            new OmKeyLocationInfoGroup(0, new ArrayList<>())))
+        .build();
   }
 
   /**
@@ -748,16 +748,16 @@ public final class OMFileRequest {
    * @return omDirectoryInfo object
    */
   public static OmDirectoryInfo getDirectoryInfo(OmKeyInfo keyInfo) {
-    OmDirectoryInfo.Builder builder = new OmDirectoryInfo.Builder();
-    builder.setParentObjectID(keyInfo.getParentObjectID());
-    builder.setAcls(keyInfo.getAcls());
-    builder.addAllMetadata(keyInfo.getMetadata());
-    builder.setCreationTime(keyInfo.getCreationTime());
-    builder.setModificationTime(keyInfo.getModificationTime());
-    builder.setObjectID(keyInfo.getObjectID());
-    builder.setUpdateID(keyInfo.getUpdateID());
-    builder.setName(OzoneFSUtils.getFileName(keyInfo.getKeyName()));
-    return builder.build();
+    return new OmDirectoryInfo.Builder()
+        .setParentObjectID(keyInfo.getParentObjectID())
+        .setAcls(keyInfo.getAcls())
+        .addAllMetadata(keyInfo.getMetadata())
+        .setCreationTime(keyInfo.getCreationTime())
+        .setModificationTime(keyInfo.getModificationTime())
+        .setObjectID(keyInfo.getObjectID())
+        .setUpdateID(keyInfo.getUpdateID())
+        .setName(OzoneFSUtils.getFileName(keyInfo.getKeyName()))
+        .build();
   }
 
   /**


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to