This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 0350b1d825 HDDS-9676. SORT_DATANODE audit log should include request
details (#5589)
0350b1d825 is described below
commit 0350b1d8259ea87e4f0c5fd95d4eb3a943307ff7
Author: Doroszlai, Attila <[email protected]>
AuthorDate: Tue Nov 14 13:12:51 2023 +0100
HDDS-9676. SORT_DATANODE audit log should include request details (#5589)
---
.../org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
index 7d09a7af4b..61512663a0 100644
---
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
+++
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
@@ -24,6 +24,7 @@ package org.apache.hadoop.hdds.scm.server;
import java.io.IOException;
import java.net.InetSocketAddress;
import java.util.ArrayList;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeoutException;
@@ -338,6 +339,9 @@ public class SCMBlockProtocolServer implements
public List<DatanodeDetails> sortDatanodes(List<String> nodes,
String clientMachine) {
boolean auditSuccess = true;
+ Map<String, String> auditMap = new LinkedHashMap<>();
+ auditMap.put("client", clientMachine);
+ auditMap.put("nodes", String.valueOf(nodes));
try {
NodeManager nodeManager = scm.getScmNodeManager();
Node client = null;
@@ -361,13 +365,13 @@ public class SCMBlockProtocolServer implements
} catch (Exception ex) {
auditSuccess = false;
AUDIT.logReadFailure(
- buildAuditMessageForFailure(SCMAction.SORT_DATANODE, null, ex)
+ buildAuditMessageForFailure(SCMAction.SORT_DATANODE, auditMap, ex)
);
throw ex;
} finally {
if (auditSuccess) {
AUDIT.logReadSuccess(
- buildAuditMessageForSuccess(SCMAction.SORT_DATANODE, null)
+ buildAuditMessageForSuccess(SCMAction.SORT_DATANODE, auditMap)
);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
