This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 74de0705c9 HDDS-9784. Reduce default log.appender.wait-time.min to 0us
in Datanode (#5711)
74de0705c9 is described below
commit 74de0705c916bb877eae44310f43a0d7069cdef9
Author: XiChen <[email protected]>
AuthorDate: Sun Dec 3 21:14:40 2023 +0800
HDDS-9784. Reduce default log.appender.wait-time.min to 0us in Datanode
(#5711)
---
.../container/common/statemachine/TestDatanodeConfiguration.java | 8 ++++----
.../org/apache/hadoop/hdds/conf/DatanodeRatisServerConfig.java | 8 ++++++--
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git
a/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestDatanodeConfiguration.java
b/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestDatanodeConfiguration.java
index 1d83c5c7a5..abfa2c7614 100644
---
a/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestDatanodeConfiguration.java
+++
b/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestDatanodeConfiguration.java
@@ -183,13 +183,13 @@ public class TestDatanodeConfiguration {
final DatanodeRatisServerConfig ratisConf = conf.getObject(
DatanodeRatisServerConfig.class);
- Assertions.assertEquals(1, ratisConf.getLogAppenderWaitTimeMin(),
+ Assertions.assertEquals(0, ratisConf.getLogAppenderWaitTimeMin(),
"getLogAppenderWaitTimeMin");
- assertWaitTimeMin(TimeDuration.ONE_MILLISECOND, conf);
- ratisConf.setLogAppenderWaitTimeMin(0);
- conf.setFromObject(ratisConf);
assertWaitTimeMin(TimeDuration.ZERO, conf);
+ ratisConf.setLogAppenderWaitTimeMin(1);
+ conf.setFromObject(ratisConf);
+ assertWaitTimeMin(TimeDuration.ONE_MILLISECOND, conf);
}
static void assertWaitTimeMin(TimeDuration expected,
diff --git
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/DatanodeRatisServerConfig.java
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/DatanodeRatisServerConfig.java
index 3eb0faf302..643c94ebc2 100644
---
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/DatanodeRatisServerConfig.java
+++
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/DatanodeRatisServerConfig.java
@@ -193,10 +193,14 @@ public class DatanodeRatisServerConfig {
/** @see RaftServerConfigKeys.Log.Appender#WAIT_TIME_MIN_KEY */
@Config(key = "log.appender.wait-time.min",
- defaultValue = "1ms",
+ defaultValue = "0us",
type = ConfigType.TIME,
tags = {OZONE, DATANODE, RATIS, PERFORMANCE},
- description = "Minimum wait time between two appendEntries calls."
+ description = "The minimum wait time between two appendEntries calls. " +
+ "In some error conditions, the leader may keep retrying " +
+ "appendEntries. If it happens, increasing this value to, say, " +
+ "5us (microseconds) can help avoid the leader being too busy " +
+ "retrying."
)
private long logAppenderWaitTimeMin;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
