This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 8aac3e89f3 HDDS-9955. Simplify assertions in integration tests (#5846)
8aac3e89f3 is described below
commit 8aac3e89f3a6517a9f599cdbeb7fdcaa22262495
Author: Zhaohui Wang <[email protected]>
AuthorDate: Thu Dec 21 19:41:48 2023 +0800
HDDS-9955. Simplify assertions in integration tests (#5846)
---
.../apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java | 6 +++---
.../hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java | 2 +-
.../hadoop/hdds/scm/pipeline/TestLeaderChoosePolicy.java | 4 ++--
.../apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java | 5 +++--
.../hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java | 12 ++++++------
.../ozone/client/rpc/TestOzoneRpcClientForAclAuditLog.java | 3 ++-
.../org/apache/hadoop/ozone/om/TestOmBlockVersioning.java | 3 +--
.../hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java | 2 +-
.../java/org/apache/hadoop/ozone/om/TestScmSafeMode.java | 2 +-
.../apache/hadoop/ozone/om/TestSnapshotDeletingService.java | 2 +-
.../apache/hadoop/ozone/scm/TestContainerReportWithKeys.java | 5 ++---
.../org/apache/hadoop/ozone/scm/TestFailoverWithSCMHA.java | 4 ++--
.../test/java/org/apache/hadoop/ozone/scm/TestSCMMXBean.java | 6 +++---
.../apache/hadoop/ozone/scm/TestStorageContainerManager.java | 2 +-
.../apache/hadoop/ozone/scm/TestXceiverClientManager.java | 6 +++---
.../hadoop/ozone/scm/pipeline/TestSCMPipelineMetrics.java | 2 +-
16 files changed, 33 insertions(+), 33 deletions(-)
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
index c7d19678c9..73d1301f0f 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
@@ -1919,9 +1919,9 @@ public class TestRootedOzoneFileSystem {
ContractTestUtils.touch(fs, childFolderFile);
}
- assertTrue(fs.listStatus(grandparent).length == 1);
- assertTrue(fs.listStatus(parent).length == 9);
- assertTrue(fs.listStatus(childFolder).length == 8);
+ assertEquals(1, fs.listStatus(grandparent).length);
+ assertEquals(9, fs.listStatus(parent).length);
+ assertEquals(8, fs.listStatus(childFolder).length);
Boolean successResult = fs.delete(grandparent, true);
assertTrue(successResult);
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java
index 49da3e7218..73060701b7 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java
@@ -201,7 +201,7 @@ public class TestRootedOzoneFileSystemWithFSO
assertTrue(getFs().delete(bucketPath2, true));
assertTrue(getFs().delete(volumePath1, false));
long deletes = getOMMetrics().getNumKeyDeletes();
- assertTrue(deletes == prevDeletes + 1);
+ assertEquals(prevDeletes + 1, deletes);
}
/**
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestLeaderChoosePolicy.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestLeaderChoosePolicy.java
index a695038d44..725b17ee9d 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestLeaderChoosePolicy.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestLeaderChoosePolicy.java
@@ -94,9 +94,9 @@ public class TestLeaderChoosePolicy {
leaderCount.put(leader, leaderCount.get(leader) + 1);
}
- assertTrue(leaderCount.size() == dnNum);
+ assertEquals(dnNum, leaderCount.size());
for (Map.Entry<UUID, Integer> entry: leaderCount.entrySet()) {
- assertTrue(leaderCount.get(entry.getKey()) == leaderNumOfEachDn);
+ assertEquals(leaderNumOfEachDn, leaderCount.get(entry.getKey()));
}
}
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
index 99dd1d1768..6d523b21df 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
@@ -63,6 +63,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
/**
* Tests for Pipeline Closing.
@@ -229,7 +230,7 @@ public class TestPipelineClose {
try {
pipelineManager.getPipeline(openPipeline.getId());
} catch (PipelineNotFoundException e) {
- assertTrue(false, "pipeline should exist");
+ fail("pipeline should exist");
}
DatanodeDetails datanodeDetails = openPipeline.getNodes().get(0);
@@ -275,6 +276,6 @@ public class TestPipelineClose {
}
assertTrue(found, "SCM did not receive a Close action for the Pipeline");
- return found;
+ return true;
}
}
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
index 1e5dc26d84..6d19c1ad38 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
@@ -634,7 +634,7 @@ public abstract class TestOzoneRpcClientAbstract {
volume.createBucket(bucketName, builder.build());
OzoneBucket bucket = volume.getBucket(bucketName);
assertEquals(bucketName, bucket.getName());
- assertEquals(true, bucket.getVersioning());
+ assertTrue(bucket.getVersioning());
}
@Test
@@ -708,7 +708,7 @@ public abstract class TestOzoneRpcClientAbstract {
volume.createBucket(bucketName, builder.build());
OzoneBucket bucket = volume.getBucket(bucketName);
assertEquals(bucketName, bucket.getName());
- assertEquals(true, bucket.getVersioning());
+ assertTrue(bucket.getVersioning());
assertEquals(StorageType.SSD, bucket.getStorageType());
assertTrue(bucket.getAcls().contains(userAcl));
assertEquals(repConfig, bucket.getReplicationConfig());
@@ -812,7 +812,7 @@ public abstract class TestOzoneRpcClientAbstract {
bucket.setVersioning(true);
OzoneBucket newBucket = volume.getBucket(bucketName);
assertEquals(bucketName, newBucket.getName());
- assertEquals(true, newBucket.getVersioning());
+ assertTrue(newBucket.getVersioning());
}
@Test
@@ -830,7 +830,7 @@ public abstract class TestOzoneRpcClientAbstract {
OzoneBucket newBucket = volume.getBucket(bucketName);
assertEquals(bucketName, newBucket.getName());
- assertEquals(true, newBucket.getVersioning());
+ assertTrue(newBucket.getVersioning());
List<OzoneAcl> aclsAfterSet = newBucket.getAcls();
assertEquals(currentAcls, aclsAfterSet);
@@ -3796,7 +3796,7 @@ public abstract class TestOzoneRpcClientAbstract {
assertTrue(latestVersionLocations.isMultipartKey());
latestVersionLocations.getBlocksLatestVersionOnly()
.forEach(omKeyLocationInfo ->
- assertTrue(omKeyLocationInfo.getPartNumber() != -1));
+ assertNotEquals(-1, omKeyLocationInfo.getPartNumber()));
}
private String initiateMultipartUpload(OzoneBucket bucket, String keyName,
@@ -3996,7 +3996,7 @@ public abstract class TestOzoneRpcClientAbstract {
assertEquals("true", key.getMetadata().get(OzoneConsts.GDPR_FLAG));
assertEquals("AES",
key.getMetadata().get(OzoneConsts.GDPR_ALGORITHM));
- assertTrue(key.getMetadata().get(OzoneConsts.GDPR_SECRET) != null);
+ assertNotNull(key.getMetadata().get(OzoneConsts.GDPR_SECRET));
try (OzoneInputStream is = bucket.readKey(keyName)) {
assertInputStreamContent(text, is);
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientForAclAuditLog.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientForAclAuditLog.java
index 3f7c590bf6..d2ace27dc3 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientForAclAuditLog.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientForAclAuditLog.java
@@ -64,6 +64,7 @@ import static
org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ADMINISTRATORS;
import static
org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_ADMINISTRATORS_WILDCARD;
import static
org.apache.hadoop.ozone.security.acl.OzoneObj.ResourceType.VOLUME;
import static org.apache.hadoop.ozone.security.acl.OzoneObj.StoreType.OZONE;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
/**
@@ -287,7 +288,7 @@ public class TestOzoneRpcClientForAclAuditLog {
try {
// When log entry is expected, the log file will contain one line and
// that must be equal to the expected string
- assertTrue(lines.size() != 0);
+ assertNotEquals(0, lines.size());
for (String exp: expected) {
assertTrue(lines.get(0).contains(exp));
}
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmBlockVersioning.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmBlockVersioning.java
index 428bfa7305..7b8d6653d9 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmBlockVersioning.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmBlockVersioning.java
@@ -39,7 +39,6 @@ import org.apache.commons.lang3.RandomStringUtils;
import static
org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.ONE;
import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
@@ -144,7 +143,7 @@ public class TestOmBlockVersioning {
List<OmKeyLocationInfo> locationInfoList =
openKey.getKeyInfo().getLatestVersionLocations()
.getBlocksLatestVersionOnly();
- assertTrue(locationInfoList.size() == 1);
+ assertEquals(1, locationInfoList.size());
locationInfoList.add(locationInfo);
keyArgs.setLocationInfoList(locationInfoList);
writeClient.commitKey(keyArgs, openKey.getId());
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
index 977bb0d4e9..1c751bc99a 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
@@ -294,7 +294,7 @@ public class TestOzoneManagerListVolumesSecure {
Callable<Boolean> callable) {
// Some thread (eg: HeartbeatEndpointTask) will use the login ugi,
// so we could not use loginUserFromKeytabAndReturnUGI to switch user.
- assertEquals(true, ugi.doAs((PrivilegedAction<Boolean>) () -> {
+ assertTrue(ugi.doAs((PrivilegedAction<Boolean>) () -> {
try {
return callable.call();
} catch (Throwable ex) {
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestScmSafeMode.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestScmSafeMode.java
index 1d3aaf351f..d682c7f8f3 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestScmSafeMode.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestScmSafeMode.java
@@ -272,7 +272,7 @@ public class TestScmSafeMode {
scm = cluster.getStorageContainerManager();
assertTrue(scm.isInSafeMode());
assertFalse(logCapturer.getOutput().contains("SCM exiting safe mode."));
- assertTrue(scm.getCurrentContainerThreshold() == 0);
+ assertEquals(0, scm.getCurrentContainerThreshold());
for (HddsDatanodeService dn : cluster.getHddsDatanodes()) {
dn.start();
}
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java
index 98c23b8076..a14255d3c1 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java
@@ -407,7 +407,7 @@ public class TestSnapshotDeletingService {
RepeatedOmKeyInfo activeDBDeleted = next.getValue();
OMMetadataManager metadataManager =
cluster.getOzoneManager().getMetadataManager();
- assertEquals(activeDBDeleted.getOmKeyInfoList().size(), 1);
+ assertEquals(1, activeDBDeleted.getOmKeyInfoList().size());
OmKeyInfo activeDbDeletedKeyInfo =
activeDBDeleted.getOmKeyInfoList().get(0);
long volumeId = metadataManager
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
index bdbe4107fb..a30e3db221 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
@@ -140,9 +140,8 @@ public class TestContainerReportWithKeys {
Set<ContainerReplica> replicas =
scm.getContainerManager().getContainerReplicas(
ContainerID.valueOf(keyInfo.getContainerID()));
- Assert.assertTrue(replicas.size() == 1);
- replicas.stream().forEach(rp ->
- Assert.assertTrue(rp.getDatanodeDetails().getParent() != null));
+ Assert.assertEquals(1, replicas.size());
+ replicas.stream().forEach(rp ->
Assert.assertNotNull(rp.getDatanodeDetails().getParent()));
LOG.info("SCM Container Info keyCount: {} usedBytes: {}",
cinfo.getNumberOfKeys(), cinfo.getUsedBytes());
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestFailoverWithSCMHA.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestFailoverWithSCMHA.java
index e1d1ba31d7..43a2e2603e 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestFailoverWithSCMHA.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestFailoverWithSCMHA.java
@@ -115,7 +115,7 @@ public class TestFailoverWithSCMHA {
scmClientConfig.setRetryCount(1);
scmClientConfig.setRetryInterval(100);
scmClientConfig.setMaxRetryTimeout(1500);
- assertEquals(scmClientConfig.getRetryCount(), 15);
+ assertEquals(15, scmClientConfig.getRetryCount());
conf.setFromObject(scmClientConfig);
StorageContainerManager scm = getLeader(cluster);
assertNotNull(scm);
@@ -161,7 +161,7 @@ public class TestFailoverWithSCMHA {
scmClientConfig.setRetryCount(1);
scmClientConfig.setRetryInterval(100);
scmClientConfig.setMaxRetryTimeout(1500);
- assertEquals(scmClientConfig.getRetryCount(), 15);
+ assertEquals(15, scmClientConfig.getRetryCount());
conf.setFromObject(scmClientConfig);
StorageContainerManager scm = getLeader(cluster);
assertNotNull(scm);
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestSCMMXBean.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestSCMMXBean.java
index a3314f59e7..94019ed1d6 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestSCMMXBean.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestSCMMXBean.java
@@ -159,12 +159,12 @@ public class TestSCMMXBean {
containerStateCount.forEach((k, v) -> {
if (k.equals(HddsProtos.LifeCycleState.CLOSING.toString())) {
- assertEquals((int)v, 5);
+ assertEquals(5, (int)v);
} else if (k.equals(HddsProtos.LifeCycleState.CLOSED.toString())) {
- assertEquals((int)v, 5);
+ assertEquals(5, (int)v);
} else {
// Remaining all container state count should be zero.
- assertEquals((int)v, 0);
+ assertEquals(0, (int)v);
}
});
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java
index 6916e8cfb8..9286cfe521 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java
@@ -1073,7 +1073,7 @@ public class TestStorageContainerManager {
eventQueue.fireEvent(SCMEvents.INCREMENTAL_CONTAINER_REPORT, dndata);
eventQueue.fireEvent(SCMEvents.INCREMENTAL_CONTAINER_REPORT, dndata);
eventQueue.fireEvent(SCMEvents.INCREMENTAL_CONTAINER_REPORT, dndata);
- Assert.assertTrue(containerReportExecutors.droppedEvents() == 0);
+ Assert.assertEquals(0, containerReportExecutors.droppedEvents());
Thread.currentThread().sleep(3000);
Assert.assertEquals(containerReportExecutors.scheduledEvents(),
containerReportExecutors.queuedEvents());
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestXceiverClientManager.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestXceiverClientManager.java
index 9130a87b1a..ca85c5cf9e 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestXceiverClientManager.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestXceiverClientManager.java
@@ -117,7 +117,7 @@ public class TestXceiverClientManager {
clientManager.releaseClient(client1, true);
clientManager.releaseClient(client2, true);
clientManager.releaseClient(client3, true);
- Assertions.assertTrue(clientManager.getClientCache().size() == 0);
+ Assertions.assertEquals(0, clientManager.getClientCache().size());
}
}
@@ -159,7 +159,7 @@ public class TestXceiverClientManager {
XceiverClientSpi nonExistent1 = cache.getIfPresent(
container1.getContainerInfo().getPipelineID().getId().toString()
+ container1.getContainerInfo().getReplicationType());
- Assertions.assertEquals(null, nonExistent1);
+ Assertions.assertNull(nonExistent1);
// However container call should succeed because of refcount on the
client
ContainerProtocolCalls.createContainer(client1,
container1.getContainerInfo().getContainerID(), null);
@@ -218,7 +218,7 @@ public class TestXceiverClientManager {
XceiverClientSpi nonExistent = cache.getIfPresent(
container1.getContainerInfo().getPipelineID().getId().toString()
+ container1.getContainerInfo().getReplicationType());
- Assertions.assertEquals(null, nonExistent);
+ Assertions.assertNull(nonExistent);
// Any container operation should now fail
Throwable t = Assertions.assertThrows(IOException.class,
diff --git
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/pipeline/TestSCMPipelineMetrics.java
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/pipeline/TestSCMPipelineMetrics.java
index 53f4ce5e16..568d9679d1 100644
---
a/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/pipeline/TestSCMPipelineMetrics.java
+++
b/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/pipeline/TestSCMPipelineMetrics.java
@@ -109,7 +109,7 @@ public class TestSCMPipelineMetrics {
Pipeline pipeline = block.getPipeline();
long numBlocksAllocated = getLongCounter(
SCMPipelineMetrics.getBlockAllocationMetricName(pipeline), metrics);
- Assertions.assertEquals(numBlocksAllocated, 1);
+ Assertions.assertEquals(1, numBlocksAllocated);
// destroy the pipeline
Assertions.assertDoesNotThrow(() ->
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
