This is an automated email from the ASF dual-hosted git repository.

adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 9f475809d2 HDDS-10056. Silent failure in unit check (#5913)
9f475809d2 is described below

commit 9f475809d24598cd2b99fa62af93e638ab31860b
Author: Doroszlai, Attila <[email protected]>
AuthorDate: Wed Jan 3 13:04:22 2024 +0100

    HDDS-10056. Silent failure in unit check (#5913)
---
 hadoop-hdds/annotations/pom.xml              | 4 ++++
 hadoop-hdds/docs/pom.xml                     | 1 +
 hadoop-hdds/hadoop-dependency-client/pom.xml | 4 ++++
 hadoop-hdds/hadoop-dependency-server/pom.xml | 4 ++++
 hadoop-hdds/hadoop-dependency-test/pom.xml   | 4 ++++
 hadoop-hdds/interface-admin/pom.xml          | 4 ++++
 hadoop-hdds/interface-client/pom.xml         | 4 ++++
 hadoop-hdds/interface-server/pom.xml         | 4 ++++
 hadoop-hdds/managed-rocksdb/pom.xml          | 4 ++++
 hadoop-ozone/dev-support/checks/junit.sh     | 8 +++++++-
 10 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/hadoop-hdds/annotations/pom.xml b/hadoop-hdds/annotations/pom.xml
index 8acae01911..c6fed7287b 100644
--- a/hadoop-hdds/annotations/pom.xml
+++ b/hadoop-hdds/annotations/pom.xml
@@ -30,4 +30,8 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   </description>
   <name>Apache Ozone Annotation Processing</name>
   <packaging>jar</packaging>
+
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no tests in this module so 
far -->
+  </properties>
 </project>
diff --git a/hadoop-hdds/docs/pom.xml b/hadoop-hdds/docs/pom.xml
index 9f70149a2b..6281fd7495 100644
--- a/hadoop-hdds/docs/pom.xml
+++ b/hadoop-hdds/docs/pom.xml
@@ -29,6 +29,7 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   <packaging>jar</packaging>
 
   <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no testable code in this 
module -->
     <skipDocs>false</skipDocs>
   </properties>
 
diff --git a/hadoop-hdds/hadoop-dependency-client/pom.xml 
b/hadoop-hdds/hadoop-dependency-client/pom.xml
index 4a67af5e80..ca8fe4c12c 100644
--- a/hadoop-hdds/hadoop-dependency-client/pom.xml
+++ b/hadoop-hdds/hadoop-dependency-client/pom.xml
@@ -29,6 +29,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   <name>Apache Ozone HDDS Hadoop Client dependencies</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no tests in this module -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
diff --git a/hadoop-hdds/hadoop-dependency-server/pom.xml 
b/hadoop-hdds/hadoop-dependency-server/pom.xml
index 92064f56ff..abee8cc400 100644
--- a/hadoop-hdds/hadoop-dependency-server/pom.xml
+++ b/hadoop-hdds/hadoop-dependency-server/pom.xml
@@ -29,6 +29,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   <name>Apache Ozone HDDS Hadoop Server dependencies</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no tests in this module -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
diff --git a/hadoop-hdds/hadoop-dependency-test/pom.xml 
b/hadoop-hdds/hadoop-dependency-test/pom.xml
index 171ee878be..f1bd283f2d 100644
--- a/hadoop-hdds/hadoop-dependency-test/pom.xml
+++ b/hadoop-hdds/hadoop-dependency-test/pom.xml
@@ -29,6 +29,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   <name>Apache Ozone HDDS Hadoop Test dependencies</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no tests in this module -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
diff --git a/hadoop-hdds/interface-admin/pom.xml 
b/hadoop-hdds/interface-admin/pom.xml
index cac8a93d6c..8f38fb28db 100644
--- a/hadoop-hdds/interface-admin/pom.xml
+++ b/hadoop-hdds/interface-admin/pom.xml
@@ -29,6 +29,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   <name>Apache Ozone HDDS Admin Interface</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no testable code in this 
module -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>com.google.protobuf</groupId>
diff --git a/hadoop-hdds/interface-client/pom.xml 
b/hadoop-hdds/interface-client/pom.xml
index 4d62038d6e..76fdfad111 100644
--- a/hadoop-hdds/interface-client/pom.xml
+++ b/hadoop-hdds/interface-client/pom.xml
@@ -29,6 +29,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   <name>Apache Ozone HDDS Client Interface</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no testable code in this 
module -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>com.google.protobuf</groupId>
diff --git a/hadoop-hdds/interface-server/pom.xml 
b/hadoop-hdds/interface-server/pom.xml
index 3242dbf73e..b0e8d152b1 100644
--- a/hadoop-hdds/interface-server/pom.xml
+++ b/hadoop-hdds/interface-server/pom.xml
@@ -29,6 +29,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
   <name>Apache Ozone HDDS Server Interface</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no testable code in this 
module -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>com.google.protobuf</groupId>
diff --git a/hadoop-hdds/managed-rocksdb/pom.xml 
b/hadoop-hdds/managed-rocksdb/pom.xml
index 8ba177e454..1be630e854 100644
--- a/hadoop-hdds/managed-rocksdb/pom.xml
+++ b/hadoop-hdds/managed-rocksdb/pom.xml
@@ -27,6 +27,10 @@
   <name>Apache Ozone HDDS Managed RocksDB</name>
   <packaging>jar</packaging>
 
+  <properties>
+    <maven.test.skip>true</maven.test.skip> <!-- no tests in this module so 
far -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.ozone</groupId>
diff --git a/hadoop-ozone/dev-support/checks/junit.sh 
b/hadoop-ozone/dev-support/checks/junit.sh
index 7d66e7b7f2..6d6688c115 100755
--- a/hadoop-ozone/dev-support/checks/junit.sh
+++ b/hadoop-ozone/dev-support/checks/junit.sh
@@ -50,6 +50,7 @@ if [[ "${CHECK}" == "integration" ]] || [[ ${ITERATIONS} -gt 
1 ]]; then
 fi
 
 REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target/${CHECK}"}
+REPORT_FILE="${REPORT_DIR}/summary.txt"
 mkdir -p "$REPORT_DIR"
 
 rc=0
@@ -72,7 +73,7 @@ for i in $(seq 1 ${ITERATIONS}); do
 
   if [[ ${ITERATIONS} -gt 1 ]]; then
     REPORT_DIR="${original_report_dir}"
-    echo "Iteration ${i} exit code: ${irc}" | tee -a 
"${REPORT_DIR}/summary.txt"
+    echo "Iteration ${i} exit code: ${irc}" | tee -a "${REPORT_FILE}"
   fi
 
   if [[ ${rc} == 0 ]]; then
@@ -84,6 +85,11 @@ for i in $(seq 1 ${ITERATIONS}); do
   fi
 done
 
+# check if Maven failed due to some error other than test failure
+if [[ ${rc} -ne 0 ]] && [[ ! -s "${REPORT_FILE}" ]]; then
+  grep -m1 -F '[ERROR]' "${REPORT_DIR}/output.log" > "${REPORT_FILE}"
+fi
+
 if [[ "${OZONE_WITH_COVERAGE}" == "true" ]]; then
   #Archive combined jacoco records
   mvn -B -N jacoco:merge -Djacoco.destFile=$REPORT_DIR/jacoco-combined.exec


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to