This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new c39c554d99 HDDS-10070. Intermittent failure in
TestWritableRatisContainerProvider (#5930)
c39c554d99 is described below
commit c39c554d99776b168881b636cb25282e1e2334dd
Author: Doroszlai, Attila <[email protected]>
AuthorDate: Fri Jan 5 17:09:59 2024 +0100
HDDS-10070. Intermittent failure in TestWritableRatisContainerProvider
(#5930)
---
.../hdds/scm/pipeline/TestWritableRatisContainerProvider.java | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestWritableRatisContainerProvider.java
b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestWritableRatisContainerProvider.java
index 06a76338e5..d5d9208ada 100644
---
a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestWritableRatisContainerProvider.java
+++
b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestWritableRatisContainerProvider.java
@@ -27,12 +27,16 @@ import
org.apache.hadoop.hdds.scm.container.ContainerManager;
import org.apache.hadoop.hdds.scm.container.common.helpers.ExcludeList;
import org.apache.hadoop.hdds.scm.exceptions.SCMException;
import
org.apache.hadoop.hdds.scm.pipeline.choose.algorithms.RandomPipelineChoosePolicy;
+import org.junit.jupiter.api.RepeatedTest;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
+import org.mockito.junit.jupiter.MockitoSettings;
+import org.mockito.quality.Strictness;
import java.io.IOException;
+import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.atomic.AtomicLong;
@@ -49,6 +53,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class)
+@MockitoSettings(strictness = Strictness.LENIENT)
class TestWritableRatisContainerProvider {
private static final ReplicationConfig REPLICATION_CONFIG =
@@ -80,7 +85,7 @@ class TestWritableRatisContainerProvider {
verifyPipelineNotCreated();
}
- @Test
+ @RepeatedTest(100)
void skipsPipelineWithoutContainer() throws Exception {
Pipeline pipeline = MockPipeline.createPipeline(3);
ContainerInfo existingContainer = pipelineHasContainer(pipeline);
@@ -115,7 +120,7 @@ class TestWritableRatisContainerProvider {
}
private void existingPipelines(Pipeline... pipelines) {
- existingPipelines(asList(pipelines));
+ existingPipelines(new ArrayList<>(asList(pipelines)));
}
private void existingPipelines(List<Pipeline> pipelines) {
@@ -142,7 +147,7 @@ class TestWritableRatisContainerProvider {
when(pipelineManager.getPipelines(REPLICATION_CONFIG, OPEN, emptySet(),
emptySet()))
.thenReturn(emptyList())
- .thenReturn(singletonList(newPipeline));
+ .thenReturn(new ArrayList<>(singletonList(newPipeline)));
return pipelineHasContainer(newPipeline);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
