This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new b37fc2fb16 HDDS-11003. Eliminate code duplication in
XceiverClientGrpc#sendCommandAsync (#6805)
b37fc2fb16 is described below
commit b37fc2fb1641e7ace90ac0352de43f073fa62d1f
Author: Siyao Meng <[email protected]>
AuthorDate: Tue Jun 18 01:35:54 2024 -0700
HDDS-11003. Eliminate code duplication in
XceiverClientGrpc#sendCommandAsync (#6805)
---
.../apache/hadoop/hdds/scm/XceiverClientGrpc.java | 33 +++++++++-------------
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git
a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
index 4fb661cbff..c0596e4a92 100644
---
a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
+++
b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
@@ -555,31 +555,13 @@ public class XceiverClientGrpc extends XceiverClientSpi {
@Override
public void onNext(ContainerCommandResponseProto value) {
replyFuture.complete(value);
- metrics.decrPendingContainerOpsMetrics(request.getCmdType());
- long cost = System.currentTimeMillis() - requestTime;
- metrics.addContainerOpsLatency(request.getCmdType(),
- cost);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Executed command {} on datanode {}, cost = {}, "
- + "cmdType = {}", processForDebug(request), dn,
- cost, request.getCmdType());
- }
- semaphore.release();
+ decreasePendingMetricsAndReleaseSemaphore();
}
@Override
public void onError(Throwable t) {
replyFuture.completeExceptionally(t);
- metrics.decrPendingContainerOpsMetrics(request.getCmdType());
- long cost = System.currentTimeMillis() - requestTime;
- metrics.addContainerOpsLatency(request.getCmdType(),
- System.currentTimeMillis() - requestTime);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Executed command {} on datanode {}, cost = {}, "
- + "cmdType = {}", processForDebug(request), dn,
- cost, request.getCmdType());
- }
- semaphore.release();
+ decreasePendingMetricsAndReleaseSemaphore();
}
@Override
@@ -590,6 +572,17 @@ public class XceiverClientGrpc extends XceiverClientSpi {
processForDebug(request)));
}
}
+
+ private void decreasePendingMetricsAndReleaseSemaphore() {
+ metrics.decrPendingContainerOpsMetrics(request.getCmdType());
+ long cost = System.currentTimeMillis() - requestTime;
+ metrics.addContainerOpsLatency(request.getCmdType(), cost);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Executed command {} on datanode {}, cost = {},
cmdType = {}",
+ processForDebug(request), dn, cost,
request.getCmdType());
+ }
+ semaphore.release();
+ }
});
requestObserver.onNext(request);
requestObserver.onCompleted();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
