This is an automated email from the ASF dual-hosted git repository.
siyao pushed a commit to branch HDDS-7593
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/HDDS-7593 by this push:
new c77115abd1 HDDS-11225. Increase ipc.server.read.threadpool.size (#7007)
c77115abd1 is described below
commit c77115abd15778e9d4f00ec32d8d2b7a4a2ee670
Author: Wei-Chiu Chuang <[email protected]>
AuthorDate: Fri Aug 2 15:31:22 2024 -0700
HDDS-11225. Increase ipc.server.read.threadpool.size (#7007)
---
.../common/src/main/resources/ozone-default.xml | 9 +++++++++
.../java/org/apache/hadoop/ozone/om/OMConfigKeys.java | 3 +++
.../java/org/apache/hadoop/ozone/om/OzoneManager.java | 18 +++++++++++-------
3 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/hadoop-hdds/common/src/main/resources/ozone-default.xml
b/hadoop-hdds/common/src/main/resources/ozone-default.xml
index 6901ce3f6b..40fe929708 100644
--- a/hadoop-hdds/common/src/main/resources/ozone-default.xml
+++ b/hadoop-hdds/common/src/main/resources/ozone-default.xml
@@ -593,6 +593,15 @@
The number of RPC handler threads for OM service endpoints.
</description>
</property>
+ <property>
+ <name>ozone.om.read.threadpool</name>
+ <value>10</value>
+ <tag>OM, PERFORMANCE</tag>
+ <description>
+ The number of threads in RPC server reading from the socket for OM
service endpoints.
+ This config overrides Hadoop configuration
"ipc.server.read.threadpool.size" for Ozone Manager.
+ </description>
+ </property>
<property>
<name>ozone.om.http-address</name>
<value>0.0.0.0:9874</value>
diff --git
a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
index da7dab5c68..ccc936f385 100644
---
a/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
+++
b/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
@@ -52,6 +52,9 @@ public final class OMConfigKeys {
public static final String OZONE_OM_HANDLER_COUNT_KEY =
"ozone.om.handler.count.key";
public static final int OZONE_OM_HANDLER_COUNT_DEFAULT = 100;
+ public static final String OZONE_OM_READ_THREADPOOL_KEY =
+ "ozone.om.read.threadpool";
+ public static final int OZONE_OM_READ_THREADPOOL_DEFAULT = 10;
public static final String OZONE_OM_INTERNAL_SERVICE_ID =
"ozone.om.internal.service.id";
diff --git
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
index 387b96dcb4..03896a042e 100644
---
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
+++
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
@@ -286,6 +286,8 @@ import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_KERBEROS_KEYTAB_F
import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_KERBEROS_PRINCIPAL_KEY;
import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL;
import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL_DEFAULT;
+import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_READ_THREADPOOL_DEFAULT;
+import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_READ_THREADPOOL_KEY;
import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_S3_GPRC_SERVER_ENABLED;
import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_S3_GRPC_SERVER_ENABLED_DEFAULT;
import static
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_NAMESPACE_STRICT_S3;
@@ -1241,8 +1243,6 @@ public final class OzoneManager extends
ServiceRuntimeInfoImpl
OzoneNetUtils.getAddressWithHostNameLocal(omNodeRpcAddr);
}
- final int handlerCount = conf.getInt(OZONE_OM_HANDLER_COUNT_KEY,
- OZONE_OM_HANDLER_COUNT_DEFAULT);
RPC.setProtocolEngine(configuration, OzoneManagerProtocolPB.class,
ProtobufRpcEngine.class);
@@ -1271,8 +1271,8 @@ public final class OzoneManager extends
ServiceRuntimeInfoImpl
ReconfigureProtocolService.newReflectiveBlockingService(
reconfigureServerProtocol);
- return startRpcServer(configuration, omNodeRpcAddr, omService,
- omInterService, omAdminService, reconfigureService, handlerCount);
+ return startRpcServer(conf, omNodeRpcAddr, omService,
+ omInterService, omAdminService, reconfigureService);
}
/**
@@ -1285,7 +1285,6 @@ public final class OzoneManager extends
ServiceRuntimeInfoImpl
* (OMInterServiceProtocolPB impl)
* @param reconfigureProtocolService RPC protocol for reconfigure
* * (ReconfigureProtocolPB impl)
- * @param handlerCount RPC server handler count
* @return RPC server
* @throws IOException if there is an I/O error while creating RPC server
*/
@@ -1293,16 +1292,21 @@ public final class OzoneManager extends
ServiceRuntimeInfoImpl
InetSocketAddress addr, BlockingService clientProtocolService,
BlockingService interOMProtocolService,
BlockingService omAdminProtocolService,
- BlockingService reconfigureProtocolService,
- int handlerCount)
+ BlockingService reconfigureProtocolService)
throws IOException {
+ final int handlerCount = conf.getInt(OZONE_OM_HANDLER_COUNT_KEY,
+ OZONE_OM_HANDLER_COUNT_DEFAULT);
+ final int readThreads = conf.getInt(OZONE_OM_READ_THREADPOOL_KEY,
+ OZONE_OM_READ_THREADPOOL_DEFAULT);
+
RPC.Server rpcServer = preserveThreadName(() -> new RPC.Builder(conf)
.setProtocol(OzoneManagerProtocolPB.class)
.setInstance(clientProtocolService)
.setBindAddress(addr.getHostString())
.setPort(addr.getPort())
.setNumHandlers(handlerCount)
+ .setNumReaders(readThreads)
.setVerbose(false)
.setSecretManager(delegationTokenMgr)
.build());
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
