This is an automated email from the ASF dual-hosted git repository.
weichiu pushed a commit to branch HDDS-7593
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/HDDS-7593 by this push:
new b781b54cea HDDS-11280. Add Synchronize in
AbstractCommitWatcher.addAckDataLength (#7032)
b781b54cea is described below
commit b781b54ceabce15a7c1d50d70cdcd78977502665
Author: Ashish Kumar <[email protected]>
AuthorDate: Tue Aug 6 00:06:07 2024 +0530
HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength
(#7032)
Co-authored-by: ashishk <[email protected]>
---
.../apache/hadoop/hdds/scm/storage/AbstractCommitWatcher.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/AbstractCommitWatcher.java
b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/AbstractCommitWatcher.java
index 2bc73ce58f..fb489d0d0c 100644
---
a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/AbstractCommitWatcher.java
+++
b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/AbstractCommitWatcher.java
@@ -38,6 +38,7 @@ import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.ConcurrentSkipListMap;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeoutException;
+import java.util.concurrent.atomic.AtomicLong;
/**
* This class executes watchForCommit on ratis pipeline and releases
@@ -62,7 +63,7 @@ abstract class AbstractCommitWatcher<BUFFER> {
private final XceiverClientSpi client;
- private long totalAckDataLength;
+ private final AtomicLong totalAckDataLength = new AtomicLong();
AbstractCommitWatcher(XceiverClientSpi client) {
this.client = client;
@@ -79,13 +80,12 @@ abstract class AbstractCommitWatcher<BUFFER> {
}
/** @return the total data which has been acknowledged. */
- synchronized long getTotalAckDataLength() {
- return totalAckDataLength;
+ long getTotalAckDataLength() {
+ return totalAckDataLength.get();
}
long addAckDataLength(long acked) {
- totalAckDataLength += acked;
- return totalAckDataLength;
+ return totalAckDataLength.addAndGet(acked);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
