This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 4c77f6b9e7 HDDS-11562. Parameterize
TestSCMNodeManager#testProcessLayoutVersion (#7300)
4c77f6b9e7 is described below
commit 4c77f6b9e7f8cab550dec491dd6b75b2f86577ed
Author: Ming Wei <[email protected]>
AuthorDate: Sun Oct 13 20:24:09 2024 +0800
HDDS-11562. Parameterize TestSCMNodeManager#testProcessLayoutVersion (#7300)
---
.../apache/hadoop/hdds/scm/node/TestSCMNodeManager.java | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
index cc9133cf68..6d11cb5fe5 100644
---
a/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
+++
b/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
@@ -123,6 +123,7 @@ import static org.mockito.Mockito.eq;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.EnumSource;
import org.junit.jupiter.params.provider.MethodSource;
import org.junit.jupiter.params.provider.ValueSource;
import org.mockito.ArgumentCaptor;
@@ -850,15 +851,12 @@ public class TestSCMNodeManager {
}
}
- @Test
- public void testProcessLayoutVersion() throws IOException {
- // TODO: Refactor this class to use org.junit.jupiter so test
- // parameterization can be used.
- for (FinalizationCheckpoint checkpoint: FinalizationCheckpoint.values()) {
- LOG.info("Testing with SCM finalization checkpoint {}", checkpoint);
- testProcessLayoutVersionLowerMlv(checkpoint);
- testProcessLayoutVersionReportHigherMlv(checkpoint);
- }
+ @ParameterizedTest
+ @EnumSource(FinalizationCheckpoint.class)
+ public void testProcessLayoutVersion(FinalizationCheckpoint checkpoint)
throws IOException {
+ LOG.info("Testing with SCM finalization checkpoint {}", checkpoint);
+ testProcessLayoutVersionLowerMlv(checkpoint);
+ testProcessLayoutVersionReportHigherMlv(checkpoint);
}
// Currently invoked by testProcessLayoutVersion.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
