This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new ce07a3ccdf HDDS-11456. Require successful dependency/licence checks
for acceptance/compile/kubernetes (#7209)
ce07a3ccdf is described below
commit ce07a3ccdf02a030fbb2dfc8798500deb22dc65f
Author: Doroszlai, Attila <[email protected]>
AuthorDate: Mon Oct 14 14:37:21 2024 +0200
HDDS-11456. Require successful dependency/licence checks for
acceptance/compile/kubernetes (#7209)
---
.github/workflows/ci.yml | 6 ++++++
dev-support/ci/selective_ci_checks.bats | 30 +++++++++++++++---------------
dev-support/ci/selective_ci_checks.sh | 6 +++++-
3 files changed, 26 insertions(+), 16 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 997c0104df..4285bac399 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -169,6 +169,8 @@ jobs:
- build-info
- build
- basic
+ - dependency
+ - license
timeout-minutes: 45
if: needs.build-info.outputs.needs-compile == 'true'
strategy:
@@ -410,6 +412,8 @@ jobs:
- build-info
- build
- basic
+ - dependency
+ - license
runs-on: ubuntu-20.04
timeout-minutes: 150
if: needs.build-info.outputs.needs-compose-tests == 'true'
@@ -457,6 +461,8 @@ jobs:
- build-info
- build
- basic
+ - dependency
+ - license
runs-on: ubuntu-20.04
timeout-minutes: 60
if: needs.build-info.outputs.needs-kubernetes-tests == 'true'
diff --git a/dev-support/ci/selective_ci_checks.bats
b/dev-support/ci/selective_ci_checks.bats
index 12a7987ffb..6edd38d68f 100644
--- a/dev-support/ci/selective_ci_checks.bats
+++ b/dev-support/ci/selective_ci_checks.bats
@@ -52,7 +52,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=true
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
@@ -76,7 +76,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=true
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=true
}
@@ -100,7 +100,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=true
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=true
}
@@ -112,7 +112,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
@@ -136,7 +136,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
@@ -148,7 +148,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
@@ -160,7 +160,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
@@ -172,7 +172,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
@@ -184,7 +184,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
@@ -196,7 +196,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
@@ -208,7 +208,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=true
}
@@ -232,7 +232,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
@@ -244,7 +244,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
@@ -256,7 +256,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
@@ -268,7 +268,7 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
- assert_output -p needs-dependency-check=false
+ assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
diff --git a/dev-support/ci/selective_ci_checks.sh
b/dev-support/ci/selective_ci_checks.sh
index f6b06326a3..869d36fc6c 100755
--- a/dev-support/ci/selective_ci_checks.sh
+++ b/dev-support/ci/selective_ci_checks.sh
@@ -330,6 +330,7 @@ function check_needs_compile() {
if [[ ${match_count} != "0" ]]; then
compile_needed=true
+ dependency_check_needed=true
fi
start_end::group_end
@@ -520,6 +521,7 @@ function calculate_test_types_to_run() {
echo "Looks like ${COUNT_CORE_OTHER_CHANGED_FILES} core files changed,
running all tests."
echo
compose_tests_needed=true
+ dependency_check_needed=true
integration_tests_needed=true
kubernetes_tests_needed=true
else
@@ -527,12 +529,14 @@ function calculate_test_types_to_run() {
echo
if [[ ${COUNT_COMPOSE_CHANGED_FILES} != "0" ]] || [[
${COUNT_ROBOT_CHANGED_FILES} != "0" ]]; then
compose_tests_needed="true"
+ dependency_check_needed=true
fi
if [[ ${COUNT_INTEGRATION_CHANGED_FILES} != "0" ]]; then
integration_tests_needed="true"
fi
if [[ ${COUNT_KUBERNETES_CHANGED_FILES} != "0" ]] || [[
${COUNT_ROBOT_CHANGED_FILES} != "0" ]]; then
kubernetes_tests_needed="true"
+ dependency_check_needed=true
fi
fi
start_end::group_end
@@ -590,6 +594,7 @@ get_count_robot_files
get_count_misc_files
check_needs_build
+check_needs_dependency
check_needs_compile
# calculate basic checks to run
@@ -597,7 +602,6 @@ BASIC_CHECKS="rat"
check_needs_author
check_needs_bats
check_needs_checkstyle
-check_needs_dependency
check_needs_docs
check_needs_findbugs
check_needs_native
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
