This is an automated email from the ASF dual-hosted git repository.
sammichen pushed a commit to branch HDDS-5713
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/HDDS-5713 by this push:
new 801111c14a HDDS-12879. Use AtomicFileOutputStream to write
DiskBalancerYAML file (#8317)
801111c14a is described below
commit 801111c14a8e2dc5eb1938f78b141c9031d106df
Author: Gargi Jaiswal <[email protected]>
AuthorDate: Thu Apr 24 09:58:44 2025 +0530
HDDS-12879. Use AtomicFileOutputStream to write DiskBalancerYAML file
(#8317)
---
.../hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java
index e7c3545243..381efdd08e 100644
---
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java
+++
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java
@@ -20,9 +20,10 @@
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
-import java.io.Writer;
import java.nio.file.Files;
import org.apache.hadoop.hdds.server.YamlUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.yaml.snakeyaml.DumperOptions;
import org.yaml.snakeyaml.Yaml;
@@ -32,6 +33,9 @@
public final class DiskBalancerYaml {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(DiskBalancerYaml.class);
+
private DiskBalancerYaml() {
// static helper methods only, no state.
}
@@ -50,9 +54,8 @@ public static void createDiskBalancerInfoFile(
options.setDefaultFlowStyle(DumperOptions.FlowStyle.FLOW);
Yaml yaml = new Yaml(options);
- try (Writer writer = Files.newBufferedWriter(path.toPath())) {
- yaml.dump(getDiskBalancerInfoYaml(diskBalancerInfo), writer);
- }
+ final DiskBalancerInfoYaml data =
getDiskBalancerInfoYaml(diskBalancerInfo);
+ YamlUtils.dump(yaml, data, path, LOG);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
