This is an automated email from the ASF dual-hosted git repository.

ChenSammi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 8c89c58b254 HDDS-15257. [DiskBalancer] Add CLOSING state to the "not 
movable" check (#10254)
8c89c58b254 is described below

commit 8c89c58b254d16b6a950084e75d5ea423207c6d0
Author: Gargi Jaiswal <[email protected]>
AuthorDate: Wed May 13 18:20:17 2026 +0530

    HDDS-15257. [DiskBalancer] Add CLOSING state to the "not movable" check 
(#10254)
---
 .../ozone/container/diskbalancer/DiskBalancerConfiguration.java       | 2 +-
 .../hadoop/ozone/container/diskbalancer/TestDiskBalancerService.java  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerConfiguration.java
 
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerConfiguration.java
index c2843730cd5..2902d6962ec 100644
--- 
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerConfiguration.java
+++ 
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerConfiguration.java
@@ -347,7 +347,7 @@ private static Set<State> 
parseMovableContainerStates(String raw) {
                 + "Valid names are: " + Arrays.toString(State.values()),
             ex);
       }
-      if (HddsUtils.isOpenToWriteState(state) || state == State.DELETED) {
+      if (HddsUtils.isOpenToWriteState(state) || state == State.CLOSING || 
state == State.DELETED) {
         throw new IllegalArgumentException("State " + name + " is not 
movable.");
       }
       states.add(State.valueOf(name));
diff --git 
a/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/diskbalancer/TestDiskBalancerService.java
 
b/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/diskbalancer/TestDiskBalancerService.java
index dfe36493e5e..425733cb9e2 100644
--- 
a/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/diskbalancer/TestDiskBalancerService.java
+++ 
b/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/diskbalancer/TestDiskBalancerService.java
@@ -520,8 +520,8 @@ private static Stream<Arguments> 
movableContainerStatesCases() {
             new HashSet<>(Arrays.asList(State.CLOSED, State.QUASI_CLOSED)), 
null),
         Arguments.of("  QUASI_CLOSED  ", true,
             new HashSet<>(Arrays.asList(State.QUASI_CLOSED)), null),
-        Arguments.of("CLOSING,CLOSED", true,
-            new HashSet<>(Arrays.asList(State.CLOSING, State.CLOSED)), null),
+        Arguments.of("CLOSING,CLOSED", false, new HashSet<>(Arrays.
+                asList(State.CLOSING, State.CLOSED)), "State CLOSING is not 
movable"),
         Arguments.of("  QUASI_CLOSED,CLOSED ", true,
             new HashSet<>(Arrays.asList(State.CLOSED, State.QUASI_CLOSED)), 
null),
         Arguments.of("  QUASI_CLOSED , CLOSED ", true,


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to