This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 5cb9fabea85 HDDS-15654. Remove unused withinThresholdUtilizedNodes
list from ContainerBalancerTask (#10599)
5cb9fabea85 is described below
commit 5cb9fabea859e29eb74f817230adf1872f7c52c7
Author: sreejasahithi <[email protected]>
AuthorDate: Thu Jun 25 01:20:06 2026 +0530
HDDS-15654. Remove unused withinThresholdUtilizedNodes list from
ContainerBalancerTask (#10599)
---
.../hdds/scm/container/balancer/ContainerBalancerTask.java | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java
index 29c3fbc5848..e0281575f17 100644
---
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java
+++
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java
@@ -93,7 +93,6 @@ public class ContainerBalancerTask implements Runnable {
private long sizeActuallyMovedInLatestIteration;
private final List<DatanodeUsageInfo> overUtilizedNodes;
private final List<DatanodeUsageInfo> underUtilizedNodes;
- private List<DatanodeUsageInfo> withinThresholdUtilizedNodes;
private Set<String> excludeNodes;
private Set<String> includeNodes;
private ContainerBalancerConfiguration config;
@@ -154,7 +153,6 @@ public ContainerBalancerTask(StorageContainerManager scm,
this.scmContext = scm.getScmContext();
this.overUtilizedNodes = new ArrayList<>();
this.underUtilizedNodes = new ArrayList<>();
- this.withinThresholdUtilizedNodes = new ArrayList<>();
PlacementPolicyValidateProxy placementPolicyValidateProxy =
scm.getPlacementPolicyValidateProxy();
NetworkTopology networkTopology = scm.getClusterMap();
this.nextIterationIndex = nextIterationIndex;
@@ -533,8 +531,6 @@ private boolean initializeIteration() {
datanodeUsageInfo.getScmNodeStat().getCapacity().get(),
utilization);
totalUnderUtilizedBytes += underUtilizedBytes;
- } else {
- withinThresholdUtilizedNodes.add(datanodeUsageInfo);
}
}
metrics.incrementDataSizeUnbalancedGB(
@@ -586,8 +582,6 @@ private boolean isValidSCMState() {
private IterationResult doIteration() {
// note that potential and selected targets are updated in the following
// loop
- //TODO(jacksonyao): take withinThresholdUtilizedNodes as candidate for both
- // source and target
List<DatanodeUsageInfo> potentialTargets = getPotentialTargets();
findTargetStrategy.reInitialize(potentialTargets, config, upperLimit);
findSourceStrategy.reInitialize(getPotentialSources(), config, lowerLimit);
@@ -1082,25 +1076,21 @@ public static double
calculateAvgUtilization(List<DatanodeUsageInfo> nodes) {
/**
* Get potential targets for container move. Potential targets are under
- * utilized and within threshold utilized nodes.
+ * utilized nodes.
*
* @return A list of potential target DatanodeUsageInfo.
*/
private List<DatanodeUsageInfo> getPotentialTargets() {
- //TODO(jacksonyao): take withinThresholdUtilizedNodes as candidate for both
- // source and target
return underUtilizedNodes;
}
/**
* Get potential sourecs for container move. Potential sourecs are over
- * utilized and within threshold utilized nodes.
+ * utilized nodes.
*
* @return A list of potential source DatanodeUsageInfo.
*/
private List<DatanodeUsageInfo> getPotentialSources() {
- //TODO(jacksonyao): take withinThresholdUtilizedNodes as candidate for both
- // source and target
return overUtilizedNodes;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
