This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new a439238a8cc HDDS-16322. ConfigurationSource.getClass loads property
key instead of configured class name (#11144)
a439238a8cc is described below
commit a439238a8cccf9089f9f689f73073aa0afb4ddee
Author: Mark Tsai <[email protected]>
AuthorDate: Sat Aug 29 00:15:45 2026 +0800
HDDS-16322. ConfigurationSource.getClass loads property key instead of
configured class name (#11144)
---
.../java/org/apache/hadoop/hdds/conf/ConfigurationSource.java | 2 +-
.../java/org/apache/hadoop/hdds/conf/TestConfigurationSource.java | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git
a/hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java
b/hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java
index 5fc7c3c3ddc..4b9dae7265b 100644
---
a/hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java
+++
b/hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java
@@ -237,7 +237,7 @@ default Class<?> getClass(String name, Class<?>
defaultValue) {
return defaultValue;
}
try {
- return Class.forName(name);
+ return Class.forName(valueString);
} catch (ClassNotFoundException e) {
throw new RuntimeException(e);
}
diff --git
a/hadoop-hdds/config/src/test/java/org/apache/hadoop/hdds/conf/TestConfigurationSource.java
b/hadoop-hdds/config/src/test/java/org/apache/hadoop/hdds/conf/TestConfigurationSource.java
index f4b32060014..dbc5d07bd9b 100644
---
a/hadoop-hdds/config/src/test/java/org/apache/hadoop/hdds/conf/TestConfigurationSource.java
+++
b/hadoop-hdds/config/src/test/java/org/apache/hadoop/hdds/conf/TestConfigurationSource.java
@@ -34,6 +34,14 @@ void getPropsMatchPrefixAndTrimPrefix() {
c.getPropsMatchPrefixAndTrimPrefix("somePrefix."));
}
+ @Test
+ void getClassUsesConfiguredValueNotKey() {
+ MutableConfigurationSource c = new InMemoryConfigurationForTesting();
+ c.set("some.config.key", String.class.getName());
+
+ assertEquals(String.class, c.getClass("some.config.key", null));
+ }
+
@Test
void getPropsMatchPrefix() {
MutableConfigurationSource c = new InMemoryConfigurationForTesting();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
