This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 4455796d0f1 HDDS-16582. Improve errorprone check (#11308)
4455796d0f1 is described below
commit 4455796d0f103bb8c58157d5b39f59dbb8de8f39
Author: Doroszlai, Attila <[email protected]>
AuthorDate: Thu Sep 24 12:45:23 2026 +0200
HDDS-16582. Improve errorprone check (#11308)
---
.github/workflows/ci.yml | 19 +++++++++++++++++++
.gitignore | 1 +
dev-support/ci/errorprone.bats | 5 +++--
hadoop-ozone/dev-support/checks/errorprone.sh | 11 ++++++++++-
hadoop-ozone/pom.xml | 8 ++++++++
5 files changed, 41 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 26256a0e5f9..aebe410902d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -213,8 +213,27 @@ jobs:
strategy:
matrix:
check: ${{ fromJson(needs.build-info.outputs.basic-checks) }}
+ exclude:
+ - check: errorprone
fail-fast: false
+ errorprone:
+ needs:
+ - build-info
+ - build
+ - basic
+ if: contains(needs.build-info.outputs.basic-checks, 'errorprone')
+ uses: $/.github/workflows/check.yml
+ secrets:
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+ with:
+ java-version: ${{ needs.build-info.outputs.java-version }}
+ needs-ozone-repo: true
+ ratis-args: ${{ inputs.ratis_args }}
+ script: errorprone
+ sha: ${{ needs.build-info.outputs.sha }}
+ timeout-minutes: 30
+
dependency:
needs:
- build-info
diff --git a/.gitignore b/.gitignore
index cd18466bd9b..e17ad407d4b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -36,6 +36,7 @@ output.xml
report.html
.dev-tools
+dev-support/ci/__pycache__
dev-support/ci/bats-assert
dev-support/ci/bats-support
diff --git a/dev-support/ci/errorprone.bats b/dev-support/ci/errorprone.bats
index 49f687b671e..a77f6eb9ba5 100644
--- a/dev-support/ci/errorprone.bats
+++ b/dev-support/ci/errorprone.bats
@@ -48,8 +48,9 @@ teardown() {
run hadoop-ozone/dev-support/checks/errorprone.sh
[ "$status" -eq 1 ]
- grep -q -- '-DskipTests clean package' "${TEST_TMPDIR}/mvn-args"
- ! grep -q -- '-DskipShade' "${TEST_TMPDIR}/mvn-args"
+ grep -q -- '-DskipTests' "${TEST_TMPDIR}/mvn-args"
+ grep -q -- '-DskipShade' "${TEST_TMPDIR}/mvn-args"
+ grep -q -- 'clean package' "${TEST_TMPDIR}/mvn-args"
[ "$(wc -l < "${OUTPUT_DIR}/diagnostics.txt")" -eq 5 ]
grep -q '^\[WARNING\].*\[JdkObsolete\]' "${OUTPUT_DIR}/diagnostics.txt"
grep -q '^\[ERROR\].*\[FormatString\]' "${OUTPUT_DIR}/diagnostics.txt"
diff --git a/hadoop-ozone/dev-support/checks/errorprone.sh
b/hadoop-ozone/dev-support/checks/errorprone.sh
index 5d9fd362d54..e8b8654f659 100755
--- a/hadoop-ozone/dev-support/checks/errorprone.sh
+++ b/hadoop-ozone/dev-support/checks/errorprone.sh
@@ -26,13 +26,22 @@ REPORT_FILE="$REPORT_DIR/summary.txt"
DIAGNOSTIC_FILE="$REPORT_DIR/diagnostics.txt"
OUTPUT_LOG=$(mktemp)
-MAVEN_OPTIONS='-B -fae --no-transfer-progress -Perrorprone -DskipDocs
-DskipRecon -DskipTests'
+MAVEN_OPTIONS='-B -fae --no-transfer-progress -Perrorprone -DskipDocs
-DskipRecon -DskipShade -DskipTests'
MAVEN_DIAGNOSTIC_PATTERN='^\[(ERROR|WARNING)\] .*:\[[0-9]+,[0-9]+\] \[[^]]+\]'
JAVAC_DIAGNOSTIC_PATTERN='^.*:[0-9]+: (error|warning): \[[^]]+\]'
MAVEN_ERROR_PATTERN='^\[ERROR\] .*:\[[0-9]+,[0-9]+\] \[[^]]+\]'
JAVAC_ERROR_PATTERN='^.*:[0-9]+: error: \[[^]]+\]'
ERROR_DIAGNOSTIC_PATTERN="${MAVEN_ERROR_PATTERN}|${JAVAC_ERROR_PATTERN}"
+# timestamp prefix breaks diagnostic patterns
+MAVEN_OPTIONS="$MAVEN_OPTIONS -Dorg.slf4j.simpleLogger.showDateTime=false"
+# compiler output is not shown when getting results from local cache
+MAVEN_OPTIONS="$MAVEN_OPTIONS -Ddevelocity.cache.local.enabled=false"
+
+if [[ "${CI:-}" == "true" ]]; then
+ MAVEN_OPTIONS="$MAVEN_OPTIONS --activate-profiles CI"
+fi
+
declare -i rc
trap 'rm -f "$OUTPUT_LOG"' EXIT
diff --git a/hadoop-ozone/pom.xml b/hadoop-ozone/pom.xml
index 4ae5359a7d8..ce0cc644806 100644
--- a/hadoop-ozone/pom.xml
+++ b/hadoop-ozone/pom.xml
@@ -127,6 +127,14 @@
<module>ozonefs-shaded</module>
</modules>
</profile>
+ <profile>
+ <id>CI</id>
+ <modules>
+ <!-- assuming ozonefs-shaded is available from repo -->
+ <module>ozonefs-hadoop2</module>
+ <module>ozonefs-hadoop3</module>
+ </modules>
+ </profile>
<profile>
<id>parallel-tests</id>
<build>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
