This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-paimon-trino.git


The following commit(s) were added to refs/heads/main by this push:
     new 2109a2a  [bug] catch the exception of calling alter table (#19)
2109a2a is described below

commit 2109a2a8607922b834e54496386990d90a6f7edf
Author: miomiocat <[email protected]>
AuthorDate: Wed Jul 19 11:51:40 2023 +0800

    [bug] catch the exception of calling alter table (#19)
---
 .../src/main/java/org/apache/paimon/trino/TrinoMetadata.java |  4 ++--
 .../src/main/java/org/apache/paimon/trino/TrinoMetadata.java |  4 ++--
 .../src/main/java/org/apache/paimon/trino/TrinoMetadata.java |  4 ++--
 .../main/java/org/apache/paimon/trino/TrinoMetadataBase.java | 12 ++++++------
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git 
a/paimon-trino-368/src/main/java/org/apache/paimon/trino/TrinoMetadata.java 
b/paimon-trino-368/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
index 6e4f759..2f60a53 100644
--- a/paimon-trino-368/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
+++ b/paimon-trino-368/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
@@ -73,9 +73,9 @@ public class TrinoMetadata extends TrinoMetadataBase {
         // TODO: remove options, SET PROPERTIES x = DEFAULT
         try {
             catalog.alterTable(identifier, changes, false);
-        } catch (Catalog.TableNotExistException e) {
+        } catch (Exception e) {
             throw new RuntimeException(
-                    format("table not exists: '%s'", 
trinoTableHandle.getTableName()));
+                    format("failed to alter table: '%s'", 
trinoTableHandle.getTableName()), e);
         }
     }
 }
diff --git 
a/paimon-trino-369/src/main/java/org/apache/paimon/trino/TrinoMetadata.java 
b/paimon-trino-369/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
index 6f6525a..c998eb0 100644
--- a/paimon-trino-369/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
+++ b/paimon-trino-369/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
@@ -68,9 +68,9 @@ public class TrinoMetadata extends TrinoMetadataBase {
         // TODO: remove options, SET PROPERTIES x = DEFAULT
         try {
             catalog.alterTable(identifier, changes, false);
-        } catch (Catalog.TableNotExistException e) {
+        } catch (Exception e) {
             throw new RuntimeException(
-                    format("table not exists: '%s'", 
trinoTableHandle.getTableName()));
+                    format("failed to alter table: '%s'", 
trinoTableHandle.getTableName()), e);
         }
     }
 }
diff --git 
a/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadata.java 
b/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
index 60ce38c..9d080ef 100644
--- 
a/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
+++ 
b/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadata.java
@@ -69,9 +69,9 @@ public class TrinoMetadata extends TrinoMetadataBase {
         // TODO: remove options, SET PROPERTIES x = DEFAULT
         try {
             catalog.alterTable(identifier, changes, false);
-        } catch (Catalog.TableNotExistException e) {
+        } catch (Exception e) {
             throw new RuntimeException(
-                    format("table not exists: '%s'", 
trinoTableHandle.getTableName()));
+                    format("failed to alter table: '%s'", 
trinoTableHandle.getTableName()), e);
         }
     }
 }
diff --git 
a/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadataBase.java
 
b/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadataBase.java
index 8519656..fcb00d9 100644
--- 
a/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadataBase.java
+++ 
b/paimon-trino-common/src/main/java/org/apache/paimon/trino/TrinoMetadataBase.java
@@ -286,9 +286,9 @@ public abstract class TrinoMetadataBase implements 
ConnectorMetadata {
                         column.getName(), 
TrinoTypeUtils.toPaimonType(column.getType())));
         try {
             catalog.alterTable(identifier, changes, false);
-        } catch (Catalog.TableNotExistException e) {
+        } catch (Exception e) {
             throw new RuntimeException(
-                    format("table not exists: '%s'", 
trinoTableHandle.getTableName()));
+                    format("failed to alter table: '%s'", 
trinoTableHandle.getTableName()), e);
         }
     }
 
@@ -306,9 +306,9 @@ public abstract class TrinoMetadataBase implements 
ConnectorMetadata {
         
changes.add(SchemaChange.renameColumn(trinoColumnHandle.getColumnName(), 
target));
         try {
             catalog.alterTable(identifier, changes, false);
-        } catch (Catalog.TableNotExistException e) {
+        } catch (Exception e) {
             throw new RuntimeException(
-                    format("table not exists: '%s'", 
trinoTableHandle.getTableName()));
+                    format("failed to alter table: '%s'", 
trinoTableHandle.getTableName()), e);
         }
     }
 
@@ -323,9 +323,9 @@ public abstract class TrinoMetadataBase implements 
ConnectorMetadata {
         
changes.add(SchemaChange.dropColumn(trinoColumnHandle.getColumnName()));
         try {
             catalog.alterTable(identifier, changes, false);
-        } catch (Catalog.TableNotExistException e) {
+        } catch (Exception e) {
             throw new RuntimeException(
-                    format("table not exists: '%s'", 
trinoTableHandle.getTableName()));
+                    format("failed to alter table: '%s'", 
trinoTableHandle.getTableName()), e);
         }
     }
 

Reply via email to