(incubator-paimon) branch master updated: [hive] Fix the problem that paimon table comment cannot be synchronized to hive metastore (#2755)

[lzljs3620320]

This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new baaf45b34 [hive] Fix the problem that paimon table comment cannot be 
synchronized to hive metastore (#2755)
baaf45b34 is described below

commit baaf45b3421ff5bc7a08b8c501049e385a2c0c25
Author: herefree <841043...@qq.com>
AuthorDate: Mon Jan 22 16:26:37 2024 +0800

    [hive] Fix the problem that paimon table comment cannot be synchronized to 
hive metastore (#2755)
---
 .../src/main/java/org/apache/paimon/hive/HiveCatalog.java        | 9 ++++++---
 .../src/test/java/org/apache/paimon/hive/HiveCatalogTest.java    | 3 ++-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git 
a/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
 
b/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
index 279b83b28..ecf624c70 100644
--- 
a/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
+++ 
b/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java
@@ -95,7 +95,7 @@ public class HiveCatalog extends AbstractCatalog {
     private static final Logger LOG = 
LoggerFactory.getLogger(HiveCatalog.class);
 
     // Reserved properties
-    public static final String DB_COMMENT_PROP = "comment";
+    public static final String COMMENT_PROP = "comment";
     public static final String TABLE_TYPE_PROP = "table_type";
     public static final String PAIMON_TABLE_TYPE_VALUE = "paimon";
 
@@ -242,7 +242,7 @@ public class HiveCatalog extends AbstractCatalog {
         Map<String, String> parameter = new HashMap<>();
         properties.forEach(
                 (key, value) -> {
-                    if (key.equals(DB_COMMENT_PROP)) {
+                    if (key.equals(COMMENT_PROP)) {
                         database.setDescription(value);
                     } else if (key.equals(DB_LOCATION_PROP)) {
                         database.setLocationUri(value);
@@ -270,7 +270,7 @@ public class HiveCatalog extends AbstractCatalog {
             properties.put(DB_LOCATION_PROP, database.getLocationUri());
         }
         if (database.getDescription() != null) {
-            properties.put(DB_COMMENT_PROP, database.getDescription());
+            properties.put(COMMENT_PROP, database.getDescription());
         }
         return properties;
     }
@@ -556,6 +556,9 @@ public class HiveCatalog extends AbstractCatalog {
                             .collect(Collectors.toList()));
         }
         table.setSd(sd);
+        if (schema.comment() != null) {
+            table.getParameters().put(COMMENT_PROP, schema.comment());
+        }
 
         // update location
         locationHelper.specifyTableLocation(table, 
getDataTableLocation(identifier).toString());
diff --git 
a/paimon-hive/paimon-hive-catalog/src/test/java/org/apache/paimon/hive/HiveCatalogTest.java
 
b/paimon-hive/paimon-hive-catalog/src/test/java/org/apache/paimon/hive/HiveCatalogTest.java
index 764b672bb..ac80a276a 100644
--- 
a/paimon-hive/paimon-hive-catalog/src/test/java/org/apache/paimon/hive/HiveCatalogTest.java
+++ 
b/paimon-hive/paimon-hive-catalog/src/test/java/org/apache/paimon/hive/HiveCatalogTest.java
@@ -194,7 +194,7 @@ public class HiveCatalogTest extends CatalogTestBase {
                             Collections.emptyList(),
                             Collections.emptyList(),
                             options,
-                            "");
+                            "this is a hive table");
 
             catalog.createTable(
                     Identifier.create(databaseName, tableName),
@@ -210,6 +210,7 @@ public class HiveCatalogTest extends CatalogTestBase {
             // Verify the transformed parameters
             assertThat(tableProperties).containsEntry("table.owner", "Jon");
             assertThat(tableProperties).containsEntry("storage.format", "ORC");
+            assertThat(tableProperties).containsEntry("comment", "this is a 
hive table");
             assertThat(tableProperties)
                     .containsEntry(
                             TABLE_TYPE_PROP, 
PAIMON_TABLE_TYPE_VALUE.toUpperCase(Locale.ROOT));