(incubator-paimon-webui) branch main updated: [Bugfix] Fix incorrect display of snapshot information (#156)

[nicholasjiang]

This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-paimon-webui.git


The following commit(s) were added to refs/heads/main by this push:
     new 5c27c27  [Bugfix] Fix incorrect display of snapshot information (#156)
5c27c27 is described below

commit 5c27c273603aa030d8b6fd1c76854a2786c4fe65
Author: zhoulii <zhouli....@foxmail.com>
AuthorDate: Wed Jan 24 14:40:40 2024 +0800

    [Bugfix] Fix incorrect display of snapshot information (#156)
---
 .../paimon/web/server/data/vo/SnapshotVO.java      | 78 ++++------------------
 .../server/service/impl/MetadataServiceImpl.java   |  9 +--
 2 files changed, 19 insertions(+), 68 deletions(-)

diff --git 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/vo/SnapshotVO.java
 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/vo/SnapshotVO.java
index eeca67b..6040426 100644
--- 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/vo/SnapshotVO.java
+++ 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/vo/SnapshotVO.java
@@ -18,72 +18,22 @@
 
 package org.apache.paimon.web.server.data.vo;
 
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Data;
+import lombok.NoArgsConstructor;
+
 import java.time.LocalDateTime;
 
 /** VO of metadata snapshot. */
+@Data
+@Builder
+@NoArgsConstructor
+@AllArgsConstructor
 public class SnapshotVO {
-    private final Long snapshotId;
-    private final Long schemaId;
-    private final Long commitIdentifier;
-    private final LocalDateTime commitTime;
-
-    public SnapshotVO(
-            Long snapshotId, Long schemaId, Long commitIdentifier, 
LocalDateTime commitTime) {
-        this.snapshotId = snapshotId;
-        this.schemaId = schemaId;
-        this.commitIdentifier = commitIdentifier;
-        this.commitTime = commitTime;
-    }
-
-    public Long getSnapshotId() {
-        return snapshotId;
-    }
-
-    public Long getSchemaId() {
-        return schemaId;
-    }
-
-    public Long getCommitIdentifier() {
-        return commitIdentifier;
-    }
-
-    public LocalDateTime getCommitTime() {
-        return commitTime;
-    }
-
-    public static Builder builder() {
-        return new Builder();
-    }
-
-    /** Builder for SnapshotInfoVo. */
-    public static class Builder {
-        private Long snapshotId;
-        private Long schemaId;
-        private Long commitIdentifier;
-        private LocalDateTime commitTime;
-
-        public Builder setSnapshotId(Long snapshotId) {
-            this.snapshotId = snapshotId;
-            return this;
-        }
-
-        public Builder setSchemaId(Long schemaId) {
-            this.schemaId = schemaId;
-            return this;
-        }
-
-        public Builder setCommitIdentifier(Long commitIdentifier) {
-            this.commitIdentifier = commitIdentifier;
-            return this;
-        }
-
-        public Builder setCommitTime(LocalDateTime commitTime) {
-            this.commitTime = commitTime;
-            return this;
-        }
-
-        public SnapshotVO build() {
-            return new SnapshotVO(snapshotId, schemaId, commitIdentifier, 
commitTime);
-        }
-    }
+    private Long snapshotId;
+    private Long schemaId;
+    private Long commitIdentifier;
+    private String commitKind;
+    private LocalDateTime commitTime;
 }
diff --git 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/MetadataServiceImpl.java
 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/MetadataServiceImpl.java
index d9e1611..e980a80 100644
--- 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/MetadataServiceImpl.java
+++ 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/MetadataServiceImpl.java
@@ -108,10 +108,11 @@ public class MetadataServiceImpl implements 
MetadataService {
                     internalRow -> {
                         SnapshotVO build =
                                 SnapshotVO.builder()
-                                        .setSnapshotId(internalRow.getLong(0))
-                                        .setSnapshotId(internalRow.getLong(1))
-                                        
.setCommitIdentifier(internalRow.getLong(3))
-                                        .setCommitTime(
+                                        .snapshotId(internalRow.getLong(0))
+                                        .schemaId(internalRow.getLong(1))
+                                        
.commitIdentifier(internalRow.getLong(3))
+                                        
.commitKind(internalRow.getString(4).toString())
+                                        .commitTime(
                                                 internalRow.getTimestamp(5, 
3).toLocalDateTime())
                                         .build();
                         result.add(build);