This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new 0c15e56e2 [hotfix] Remove redundant and unused test code (#3066)
0c15e56e2 is described below

commit 0c15e56e2c04ce0d448282ef422ecda2752139f9
Author: yuzelin <[email protected]>
AuthorDate: Thu Mar 21 13:54:53 2024 +0800

    [hotfix] Remove redundant and unused test code (#3066)
---
 .../org/apache/paimon/flink/CatalogITCaseBase.java | 11 ----
 .../paimon/flink/RemoteLookupJoinITCase.java       |  4 +-
 .../apache/paimon/flink/sink/FlinkSinkTest.java    | 62 ----------------------
 3 files changed, 2 insertions(+), 75 deletions(-)

diff --git 
a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/CatalogITCaseBase.java
 
b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/CatalogITCaseBase.java
index 20ebdd505..79f1079a2 100644
--- 
a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/CatalogITCaseBase.java
+++ 
b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/CatalogITCaseBase.java
@@ -98,17 +98,6 @@ public abstract class CatalogITCaseBase extends 
AbstractTestBase {
         prepareEnv();
     }
 
-    protected Table getPaimonTable(String tableName) {
-        FlinkCatalog flinkCatalog = (FlinkCatalog) 
tEnv.getCatalog(tEnv.getCurrentCatalog()).get();
-        try {
-            return flinkCatalog
-                    .catalog()
-                    .getTable(new Identifier(tEnv.getCurrentDatabase(), 
tableName));
-        } catch (org.apache.paimon.catalog.Catalog.TableNotExistException e) {
-            throw new RuntimeException(e);
-        }
-    }
-
     protected Map<String, String> catalogOptions() {
         return Collections.emptyMap();
     }
diff --git 
a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/RemoteLookupJoinITCase.java
 
b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/RemoteLookupJoinITCase.java
index 143b4f396..9e7aac281 100644
--- 
a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/RemoteLookupJoinITCase.java
+++ 
b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/RemoteLookupJoinITCase.java
@@ -67,7 +67,7 @@ public class RemoteLookupJoinITCase extends CatalogITCaseBase 
{
         sql(
                 "CREATE TABLE DIM (k INT PRIMARY KEY NOT ENFORCED, v INT) WITH 
('bucket' = '2', 'continuous.discovery-interval' = '1ms')");
         CloseableIterator<Row> service = streamSqlIter("CALL 
sys.query_service('default.DIM', 2)");
-        RemoteTableQuery query = new RemoteTableQuery(getPaimonTable("DIM"));
+        RemoteTableQuery query = new RemoteTableQuery(paimonTable("DIM"));
 
         sql("INSERT INTO DIM VALUES (1, 11), (2, 22), (3, 33), (4, 44)");
         Thread.sleep(2000);
@@ -132,7 +132,7 @@ public class RemoteLookupJoinITCase extends 
CatalogITCaseBase {
     }
 
     private ServiceProxy launchQueryServer(String tableName) throws Throwable {
-        FileStoreTable table = (FileStoreTable) getPaimonTable(tableName);
+        FileStoreTable table = (FileStoreTable) paimonTable(tableName);
         LocalTableQuery query = 
table.newLocalTableQuery().withIOManager(IOManager.create(path));
         KvQueryServer server =
                 new KvQueryServer(
diff --git 
a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/FlinkSinkTest.java
 
b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/FlinkSinkTest.java
index 23b983b06..2a1022dce 100644
--- 
a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/FlinkSinkTest.java
+++ 
b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/FlinkSinkTest.java
@@ -37,22 +37,17 @@ import org.apache.paimon.types.DataType;
 import org.apache.paimon.types.DataTypes;
 import org.apache.paimon.types.RowType;
 
-import org.apache.flink.api.common.ExecutionConfig;
 import org.apache.flink.api.common.RuntimeExecutionMode;
 import org.apache.flink.api.common.state.ListState;
 import org.apache.flink.api.common.state.ListStateDescriptor;
-import org.apache.flink.api.common.typeutils.TypeSerializer;
-import org.apache.flink.api.java.tuple.Tuple2;
 import org.apache.flink.runtime.io.disk.iomanager.IOManagerAsync;
 import org.apache.flink.runtime.state.StateInitializationContextImpl;
 import org.apache.flink.streaming.api.datastream.DataStream;
 import org.apache.flink.streaming.api.datastream.DataStreamSource;
 import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
-import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
 import org.apache.flink.streaming.api.operators.SimpleOperatorFactory;
 import 
org.apache.flink.streaming.api.operators.collect.utils.MockOperatorStateStore;
 import org.apache.flink.streaming.api.transformations.OneInputTransformation;
-import org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
@@ -139,61 +134,4 @@ public class FlinkSinkTest {
                 options,
                 new CatalogEnvironment(Lock.emptyFactory(), null, null));
     }
-
-    private OneInputStreamOperatorTestHarness<InternalRow, Committable> 
createTestHarness(
-            OneInputStreamOperator<InternalRow, Committable> operator) throws 
Exception {
-        TypeSerializer<Committable> serializer =
-                new CommittableTypeInfo().createSerializer(new 
ExecutionConfig());
-        OneInputStreamOperatorTestHarness<InternalRow, Committable> harness =
-                new OneInputStreamOperatorTestHarness<>(operator);
-        harness.setup(serializer);
-        return harness;
-    }
-
-    private OneInputStreamOperatorTestHarness<Tuple2<InternalRow, Integer>, 
Committable>
-            createDynamicBucketTestHarness(
-                    OneInputStreamOperator<Tuple2<InternalRow, Integer>, 
Committable> operator)
-                    throws Exception {
-        TypeSerializer<Committable> serializer =
-                new CommittableTypeInfo().createSerializer(new 
ExecutionConfig());
-        OneInputStreamOperatorTestHarness<Tuple2<InternalRow, Integer>, 
Committable> harness =
-                new OneInputStreamOperatorTestHarness<>(operator);
-        harness.setup(serializer);
-        return harness;
-    }
-
-    protected RowDataStoreWriteOperator createWriteOperator(FileStoreTable 
table) {
-        return new RowDataStoreWriteOperator(
-                table,
-                null,
-                (t, commitUser, state, ioManager, memoryPool, metricGroup) ->
-                        new StoreSinkWriteImpl(
-                                t,
-                                commitUser,
-                                state,
-                                ioManager,
-                                false,
-                                false,
-                                true,
-                                memoryPool,
-                                metricGroup),
-                "test");
-    }
-
-    protected DynamicBucketRowWriteOperator 
createDynamicBucketWriteOperator(FileStoreTable table) {
-        return new DynamicBucketRowWriteOperator(
-                table,
-                (t, commitUser, state, ioManager, memoryPool, metricGroup) ->
-                        new StoreSinkWriteImpl(
-                                t,
-                                commitUser,
-                                state,
-                                ioManager,
-                                false,
-                                false,
-                                true,
-                                memoryPool,
-                                metricGroup),
-                "test");
-    }
 }

Reply via email to