(paimon-webui) branch main updated: [Bugfix] Unify comment field of table column (#362)

[nicholasjiang]

This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/paimon-webui.git


The following commit(s) were added to refs/heads/main by this push:
     new a2e7fa5e [Bugfix] Unify comment field of table column (#362)
a2e7fa5e is described below

commit a2e7fa5e5d83316d13b5b0db749e322b3eb667f1
Author: XianmingZhou00 <147145809+xianmingzho...@users.noreply.github.com>
AuthorDate: Thu Jun 13 13:45:24 2024 +0800

    [Bugfix] Unify comment field of table column (#362)
---
 .../apache/paimon/web/server/data/model/MetadataFieldsModel.java | 2 +-
 .../paimon/web/server/controller/MetadataControllerTest.java     | 9 +++++----
 paimon-web-ui/src/api/models/catalog/types/schema.ts             | 2 +-
 paimon-web-ui/src/views/metadata/components/schema/columns.ts    | 2 +-
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/MetadataFieldsModel.java
 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/MetadataFieldsModel.java
index 43fdf46e..cec8c60f 100644
--- 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/MetadataFieldsModel.java
+++ 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/MetadataFieldsModel.java
@@ -34,5 +34,5 @@ public class MetadataFieldsModel {
 
     private String type;
 
-    private String comment;
+    private String description;
 }
diff --git 
a/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/MetadataControllerTest.java
 
b/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/MetadataControllerTest.java
index f099a9bd..fe7cceeb 100644
--- 
a/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/MetadataControllerTest.java
+++ 
b/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/MetadataControllerTest.java
@@ -310,10 +310,11 @@ public class MetadataControllerTest extends 
ControllerTestBase {
         assertEquals(4, schemaVO.getFields().size());
         ArrayList<MetadataFieldsModel> expectedFields =
                 Lists.newArrayList(
-                        new MetadataFieldsModel(0, "id", "INT NOT NULL", null),
-                        new MetadataFieldsModel(1, "name", "STRING NOT NULL", 
null),
-                        new MetadataFieldsModel(2, "age", "INT NOT NULL", 
null),
-                        new MetadataFieldsModel(3, "create_time", "STRING NOT 
NULL", null));
+                        new MetadataFieldsModel(0, "id", "INT NOT NULL", "pk"),
+                        new MetadataFieldsModel(1, "name", "STRING NOT NULL", 
""),
+                        new MetadataFieldsModel(2, "age", "INT NOT NULL", ""),
+                        new MetadataFieldsModel(
+                                3, "create_time", "STRING NOT NULL", 
"partition key"));
         assertEquals(expectedFields, schemaVO.getFields());
 
         assertEquals(3, schemaVO.getOption().size());
diff --git a/paimon-web-ui/src/api/models/catalog/types/schema.ts 
b/paimon-web-ui/src/api/models/catalog/types/schema.ts
index da0d3018..cd05036a 100644
--- a/paimon-web-ui/src/api/models/catalog/types/schema.ts
+++ b/paimon-web-ui/src/api/models/catalog/types/schema.ts
@@ -29,7 +29,7 @@ export interface SchemaField {
   id: number
   name: string
   type: string
-  comment?: string
+  description: string
 }
 
 export interface SchemaOption {
diff --git a/paimon-web-ui/src/views/metadata/components/schema/columns.ts 
b/paimon-web-ui/src/views/metadata/components/schema/columns.ts
index 2464c8ad..729ec8e8 100644
--- a/paimon-web-ui/src/views/metadata/components/schema/columns.ts
+++ b/paimon-web-ui/src/views/metadata/components/schema/columns.ts
@@ -37,7 +37,7 @@ export const fieldsColumns: DataTableColumns<SchemaField> = [
     key: 'comment',
     align: 'center',
     render: (row) => {
-      return row.comment || '-'
+      return row.description || '-'
     },
   },
 ]