(paimon) branch master updated: [flink] Fix performance issue in CdcActionCommonUtils (#3550)

[lzljs3620320]

This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new 5d394d630 [flink] Fix performance issue in CdcActionCommonUtils (#3550)
5d394d630 is described below

commit 5d394d630c1f4e3e1d7644fbe63a0200b60a9414
Author: MOBIN <18814118...@163.com>
AuthorDate: Thu Jun 20 09:38:27 2024 +0800

    [flink] Fix performance issue in CdcActionCommonUtils (#3550)
---
 .../paimon/flink/action/cdc/CdcActionCommonUtils.java     | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git 
a/paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcActionCommonUtils.java
 
b/paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcActionCommonUtils.java
index 20740d1a7..3c5d586db 100644
--- 
a/paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcActionCommonUtils.java
+++ 
b/paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcActionCommonUtils.java
@@ -112,9 +112,10 @@ public class CdcActionCommonUtils {
                                 return field;
                             }
                             String columnLowerCase = 
field.name().toLowerCase();
-                            checkArgument(
-                                    existedFields.add(columnLowerCase),
-                                    columnDuplicateErrMsg.apply(field.name()));
+                            if (!existedFields.add(columnLowerCase)) {
+                                throw new IllegalArgumentException(
+                                        
columnDuplicateErrMsg.apply(field.name()));
+                            }
                             return field.newName(columnLowerCase);
                         })
                 .collect(Collectors.toList());
@@ -145,7 +146,9 @@ public class CdcActionCommonUtils {
             M newMap = mapSupplier.get();
             for (Map.Entry<String, T> entry : origin.entrySet()) {
                 String key = entry.getKey();
-                checkArgument(!newMap.containsKey(key.toLowerCase()), 
duplicateErrMsg.apply(key));
+                if (newMap.containsKey(key.toLowerCase())) {
+                    throw new 
IllegalArgumentException(duplicateErrMsg.apply(key));
+                }
                 newMap.put(key.toLowerCase(), entry.getValue());
             }
             return newMap;
@@ -180,7 +183,9 @@ public class CdcActionCommonUtils {
             return column;
         }
         String columnLowerCase = column.toLowerCase();
-        checkArgument(existedFields.add(columnLowerCase), 
columnDuplicateErrMsg.apply(column));
+        if (!existedFields.add(columnLowerCase)) {
+            throw new 
IllegalArgumentException(columnDuplicateErrMsg.apply(column));
+        }
         return columnLowerCase;
     }