This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new db98432d3 [hotfix] Remove useless RecordReader.forIOEachRemaining
db98432d3 is described below

commit db98432d30cdcc5afcf7596a3636e274c38f8e02
Author: Jingsong <[email protected]>
AuthorDate: Tue Sep 3 17:07:14 2024 +0800

    [hotfix] Remove useless RecordReader.forIOEachRemaining
---
 .../org/apache/paimon/reader/RecordReader.java     | 21 --------------
 .../paimon/utils/ConsumerWithIOException.java      | 33 ----------------------
 2 files changed, 54 deletions(-)

diff --git 
a/paimon-common/src/main/java/org/apache/paimon/reader/RecordReader.java 
b/paimon-common/src/main/java/org/apache/paimon/reader/RecordReader.java
index 5c7482d9d..135c27f25 100644
--- a/paimon-common/src/main/java/org/apache/paimon/reader/RecordReader.java
+++ b/paimon-common/src/main/java/org/apache/paimon/reader/RecordReader.java
@@ -20,7 +20,6 @@ package org.apache.paimon.reader;
 
 import org.apache.paimon.annotation.Public;
 import org.apache.paimon.utils.CloseableIterator;
-import org.apache.paimon.utils.ConsumerWithIOException;
 import org.apache.paimon.utils.Filter;
 
 import javax.annotation.Nullable;
@@ -164,26 +163,6 @@ public interface RecordReader<T> extends Closeable {
         }
     }
 
-    /**
-     * Performs the given action for each remaining element in {@link 
RecordReader} until all
-     * elements have been processed or the action throws an exception.
-     */
-    default void forIOEachRemaining(ConsumerWithIOException<? super T> action) 
throws IOException {
-        RecordReader.RecordIterator<T> batch;
-        T record;
-
-        try {
-            while ((batch = readBatch()) != null) {
-                while ((record = batch.next()) != null) {
-                    action.accept(record);
-                }
-                batch.releaseBatch();
-            }
-        } finally {
-            close();
-        }
-    }
-
     /** Returns a {@link RecordReader} that applies {@code function} to each 
element. */
     default <R> RecordReader<R> transform(Function<T, R> function) {
         RecordReader<T> thisReader = this;
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/utils/ConsumerWithIOException.java
 
b/paimon-common/src/main/java/org/apache/paimon/utils/ConsumerWithIOException.java
deleted file mode 100644
index 29ad38cc1..000000000
--- 
a/paimon-common/src/main/java/org/apache/paimon/utils/ConsumerWithIOException.java
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.paimon.utils;
-
-import java.io.IOException;
-
-/** A consumer with {@link IOException}. */
-@FunctionalInterface
-public interface ConsumerWithIOException<T> {
-
-    /**
-     * Performs this operation on the given argument.
-     *
-     * @param t the input argument
-     */
-    void accept(T t) throws IOException;
-}

Reply via email to