This is an automated email from the ASF dual-hosted git repository.
JingsongLi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git
The following commit(s) were added to refs/heads/master by this push:
new 8cc7724bab [api] Fix FunctionChange.UpdateDefinition.hashCode to
include name (#8518)
8cc7724bab is described below
commit 8cc7724babd66667a72aa03049f6452e965ec6ad
Author: Eunbin Son <[email protected]>
AuthorDate: Thu Jul 9 13:03:10 2026 +0900
[api] Fix FunctionChange.UpdateDefinition.hashCode to include name (#8518)
---
.../org/apache/paimon/function/FunctionChange.java | 2 +-
.../apache/paimon/function/FunctionChangeTest.java | 58 ++++++++++++++++++++++
2 files changed, 59 insertions(+), 1 deletion(-)
diff --git
a/paimon-api/src/main/java/org/apache/paimon/function/FunctionChange.java
b/paimon-api/src/main/java/org/apache/paimon/function/FunctionChange.java
index 01bcac532d..0b358a787c 100644
--- a/paimon-api/src/main/java/org/apache/paimon/function/FunctionChange.java
+++ b/paimon-api/src/main/java/org/apache/paimon/function/FunctionChange.java
@@ -299,7 +299,7 @@ public interface FunctionChange extends Serializable {
@Override
public int hashCode() {
- return Objects.hash(definition, definition);
+ return Objects.hash(name, definition);
}
}
diff --git
a/paimon-api/src/test/java/org/apache/paimon/function/FunctionChangeTest.java
b/paimon-api/src/test/java/org/apache/paimon/function/FunctionChangeTest.java
new file mode 100644
index 0000000000..a0514c048f
--- /dev/null
+++
b/paimon-api/src/test/java/org/apache/paimon/function/FunctionChangeTest.java
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.function;
+
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/** Test for {@link FunctionChange}. */
+public class FunctionChangeTest {
+
+ @Test
+ void testUpdateDefinitionHashCodeIncludesName() {
+ FunctionDefinition definition = FunctionDefinition.sql("SELECT 1");
+ FunctionChange a = FunctionChange.updateDefinition("f1", definition);
+ FunctionChange b = FunctionChange.updateDefinition("f2", definition);
+
+ assertThat(a).isNotEqualTo(b);
+ assertThat(a.hashCode()).isNotEqualTo(b.hashCode());
+ }
+
+ @Test
+ void testUpdateDefinitionEqualsHashCodeConsistency() {
+ FunctionDefinition definition = FunctionDefinition.sql("SELECT 1");
+ FunctionChange a = FunctionChange.updateDefinition("f1", definition);
+ FunctionChange b =
+ FunctionChange.updateDefinition("f1",
FunctionDefinition.sql("SELECT 1"));
+
+ assertThat(a).isEqualTo(b);
+ assertThat(a.hashCode()).isEqualTo(b.hashCode());
+ }
+
+ @Test
+ void testAddDefinitionHashCodeIncludesName() {
+ FunctionDefinition definition = FunctionDefinition.sql("SELECT 1");
+ FunctionChange a = FunctionChange.addDefinition("f1", definition);
+ FunctionChange b = FunctionChange.addDefinition("f2", definition);
+
+ assertThat(a).isNotEqualTo(b);
+ assertThat(a.hashCode()).isNotEqualTo(b.hashCode());
+ }
+}
