This is an automated email from the ASF dual-hosted git repository.

JingsongLi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new f2056768cb [core] Simplify manifest serializer rows
f2056768cb is described below

commit f2056768cb39cdd7b5d9240751fb2b84b6302022
Author: JingsongLi <[email protected]>
AuthorDate: Wed Aug 5 17:10:16 2026 +0800

    [core] Simplify manifest serializer rows
---
 .../paimon/manifest/IndexManifestEntrySerializer.java |  6 +-----
 .../paimon/manifest/ManifestEntrySerializer.java      | 19 +++++++------------
 .../paimon/manifest/ManifestFileMetaSerializer.java   |  6 +-----
 .../LegacyManifestFileMetaSerializerPaimon10.java     | 19 ++++++++-----------
 4 files changed, 17 insertions(+), 33 deletions(-)

diff --git 
a/paimon-core/src/main/java/org/apache/paimon/manifest/IndexManifestEntrySerializer.java
 
b/paimon-core/src/main/java/org/apache/paimon/manifest/IndexManifestEntrySerializer.java
index ca691a55a1..496ee70835 100644
--- 
a/paimon-core/src/main/java/org/apache/paimon/manifest/IndexManifestEntrySerializer.java
+++ 
b/paimon-core/src/main/java/org/apache/paimon/manifest/IndexManifestEntrySerializer.java
@@ -22,7 +22,6 @@ import org.apache.paimon.data.BinaryRow;
 import org.apache.paimon.data.GenericArray;
 import org.apache.paimon.data.GenericRow;
 import org.apache.paimon.data.InternalRow;
-import org.apache.paimon.data.JoinedRow;
 import org.apache.paimon.index.GlobalIndexMeta;
 import org.apache.paimon.index.IndexFileMeta;
 import org.apache.paimon.utils.ObjectSerializer;
@@ -52,10 +51,6 @@ public class IndexManifestEntrySerializer extends 
ObjectSerializer<IndexManifest
 
     @Override
     public InternalRow toRow(IndexManifestEntry record) {
-        return new JoinedRow().replace(GenericRow.of(FORMAT_IDENTIFIER), 
toDataRow(record));
-    }
-
-    private InternalRow toDataRow(IndexManifestEntry record) {
         IndexFileMeta indexFile = record.indexFile();
         GlobalIndexMeta globalIndexMeta = indexFile.globalIndexMeta();
         InternalRow globalIndexRow =
@@ -71,6 +66,7 @@ public class IndexManifestEntrySerializer extends 
ObjectSerializer<IndexManifest
                                 globalIndexMeta.indexMeta(),
                                 globalIndexMeta.sourceMeta());
         return GenericRow.of(
+                FORMAT_IDENTIFIER,
                 record.kind().toByteValue(),
                 serializeBinaryRow(record.partition()),
                 record.bucket(),
diff --git 
a/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestEntrySerializer.java
 
b/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestEntrySerializer.java
index 6ab15761f7..ec52247eba 100644
--- 
a/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestEntrySerializer.java
+++ 
b/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestEntrySerializer.java
@@ -21,7 +21,6 @@ package org.apache.paimon.manifest;
 import org.apache.paimon.data.BinaryRow;
 import org.apache.paimon.data.GenericRow;
 import org.apache.paimon.data.InternalRow;
-import org.apache.paimon.data.JoinedRow;
 import org.apache.paimon.io.DataFileMeta;
 import org.apache.paimon.io.DataFileMetaSerializer;
 import org.apache.paimon.utils.ObjectSerializer;
@@ -53,17 +52,13 @@ public class ManifestEntrySerializer extends 
ObjectSerializer<ManifestEntry> {
 
     @Override
     public InternalRow toRow(ManifestEntry entry) {
-        return new JoinedRow().replace(GenericRow.of(FORMAT_IDENTIFIER), 
toDataRow(entry));
-    }
-
-    private InternalRow toDataRow(ManifestEntry entry) {
-        GenericRow row = new GenericRow(5);
-        row.setField(0, entry.kind().toByteValue());
-        row.setField(1, serializeBinaryRow(entry.partition()));
-        row.setField(2, entry.bucket());
-        row.setField(3, entry.totalBuckets());
-        row.setField(4, dataFileMetaSerializer.toRow(entry.file()));
-        return row;
+        return GenericRow.of(
+                FORMAT_IDENTIFIER,
+                entry.kind().toByteValue(),
+                serializeBinaryRow(entry.partition()),
+                entry.bucket(),
+                entry.totalBuckets(),
+                dataFileMetaSerializer.toRow(entry.file()));
     }
 
     @Override
diff --git 
a/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFileMetaSerializer.java
 
b/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFileMetaSerializer.java
index c71362f92e..4c07493242 100644
--- 
a/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFileMetaSerializer.java
+++ 
b/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFileMetaSerializer.java
@@ -21,7 +21,6 @@ package org.apache.paimon.manifest;
 import org.apache.paimon.data.BinaryString;
 import org.apache.paimon.data.GenericRow;
 import org.apache.paimon.data.InternalRow;
-import org.apache.paimon.data.JoinedRow;
 import org.apache.paimon.stats.SimpleStats;
 import org.apache.paimon.utils.ObjectSerializer;
 import org.apache.paimon.utils.OffsetRow;
@@ -44,11 +43,8 @@ public class ManifestFileMetaSerializer extends 
ObjectSerializer<ManifestFileMet
 
     @Override
     public InternalRow toRow(ManifestFileMeta meta) {
-        return new JoinedRow().replace(GenericRow.of(FORMAT_IDENTIFIER), 
toDataRow(meta));
-    }
-
-    private InternalRow toDataRow(ManifestFileMeta meta) {
         return GenericRow.of(
+                FORMAT_IDENTIFIER,
                 BinaryString.fromString(meta.fileName()),
                 meta.fileSize(),
                 meta.numAddedFiles(),
diff --git 
a/paimon-core/src/test/java/org/apache/paimon/manifest/LegacyManifestFileMetaSerializerPaimon10.java
 
b/paimon-core/src/test/java/org/apache/paimon/manifest/LegacyManifestFileMetaSerializerPaimon10.java
index 1b755752e7..a1a38b2638 100644
--- 
a/paimon-core/src/test/java/org/apache/paimon/manifest/LegacyManifestFileMetaSerializerPaimon10.java
+++ 
b/paimon-core/src/test/java/org/apache/paimon/manifest/LegacyManifestFileMetaSerializerPaimon10.java
@@ -21,7 +21,6 @@ package org.apache.paimon.manifest;
 import org.apache.paimon.data.BinaryString;
 import org.apache.paimon.data.GenericRow;
 import org.apache.paimon.data.InternalRow;
-import org.apache.paimon.data.JoinedRow;
 import org.apache.paimon.stats.SimpleStats;
 import org.apache.paimon.types.BigIntType;
 import org.apache.paimon.types.DataField;
@@ -57,16 +56,14 @@ public class LegacyManifestFileMetaSerializerPaimon10 
extends ObjectSerializer<M
 
     @Override
     public InternalRow toRow(ManifestFileMeta meta) {
-        return new JoinedRow()
-                .replace(
-                        GenericRow.of(FORMAT_IDENTIFIER),
-                        GenericRow.of(
-                                BinaryString.fromString(meta.fileName()),
-                                meta.fileSize(),
-                                meta.numAddedFiles(),
-                                meta.numDeletedFiles(),
-                                meta.partitionStats().toRow(),
-                                meta.schemaId()));
+        return GenericRow.of(
+                FORMAT_IDENTIFIER,
+                BinaryString.fromString(meta.fileName()),
+                meta.fileSize(),
+                meta.numAddedFiles(),
+                meta.numDeletedFiles(),
+                meta.partitionStats().toRow(),
+                meta.schemaId());
     }
 
     @Override

Reply via email to