Repository: parquet-format Updated Branches: refs/heads/master 5b806d1e8 -> 145f4df56
PARQUET-369: Add shaded SLF4J NOP binding. This silences the complaint that no logger implementation could be found. No logger implementation was possible because the class that SLF4J was trying to load had been relocated. The only options are to relocate an implementation along with SLF4J or not shade SLF4J. This adds the NOP logger to silence the warning. Author: Ryan Blue <[email protected]> Closes #32 from rdblue/PARQUET-369-fix-slf4j-binding and squashes the following commits: f993a91 [Ryan Blue] PARQUET-369: Add shaded SLF4J NOP binding. Project: http://git-wip-us.apache.org/repos/asf/parquet-format/repo Commit: http://git-wip-us.apache.org/repos/asf/parquet-format/commit/145f4df5 Tree: http://git-wip-us.apache.org/repos/asf/parquet-format/tree/145f4df5 Diff: http://git-wip-us.apache.org/repos/asf/parquet-format/diff/145f4df5 Branch: refs/heads/master Commit: 145f4df56bacd388b77ac9ff62d0b7c3c1b4eab9 Parents: 5b806d1 Author: Ryan Blue <[email protected]> Authored: Tue Oct 27 15:08:17 2015 -0700 Committer: Ryan Blue <[email protected]> Committed: Tue Oct 27 15:08:17 2015 -0700 ---------------------------------------------------------------------- pom.xml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/parquet-format/blob/145f4df5/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 1d8c815..56d8ab1 100644 --- a/pom.xml +++ b/pom.xml @@ -85,6 +85,7 @@ <properties> <maven.compiler.source>1.6</maven.compiler.source> <maven.compiler.target>1.6</maven.compiler.target> + <shade.prefix>shaded.parquet</shade.prefix> </properties> <build> @@ -141,6 +142,7 @@ <includes> <include>org.apache.thrift:libthrift</include> <include>org.slf4j:slf4j-api</include> + <include>org.slf4j:slf4j-nop</include> </includes> </artifactSet> <filters> @@ -164,11 +166,11 @@ <relocations> <relocation> <pattern>org.apache.thrift</pattern> - <shadedPattern>parquet.org.apache.thrift</shadedPattern> + <shadedPattern>${shade.prefix}.org.apache.thrift</shadedPattern> </relocation> <relocation> <pattern>org.slf4j</pattern> - <shadedPattern>parquet.org.slf4j</shadedPattern> + <shadedPattern>${shade.prefix}.org.slf4j</shadedPattern> </relocation> </relocations> </configuration> @@ -220,6 +222,11 @@ <version>1.7.2</version> </dependency> <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-nop</artifactId> + <version>1.7.2</version> + </dependency> + <dependency> <groupId>org.apache.thrift</groupId> <artifactId>libthrift</artifactId> <version>0.7.0</version>
