Repository: parquet-cpp Updated Branches: refs/heads/master 1e80321d2 -> ca3e697e7
PARQUET-658: Add virtual destructor to ColumnReader Author: Korn, Uwe <[email protected]> Closes #136 from xhochy/parquet-658 and squashes the following commits: 1e9ca77 [Korn, Uwe] PARQUET-658: Add virtual destructor to ColumnReader Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/ca3e697e Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/ca3e697e Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/ca3e697e Branch: refs/heads/master Commit: ca3e697e7d1742b3b5b1e20ad328ebe910924da8 Parents: 1e80321 Author: Korn, Uwe <[email protected]> Authored: Sun Jul 10 12:36:32 2016 -0700 Committer: Wes McKinney <[email protected]> Committed: Sun Jul 10 12:36:32 2016 -0700 ---------------------------------------------------------------------- src/parquet/column/reader.cc | 2 ++ src/parquet/column/reader.h | 2 ++ 2 files changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/ca3e697e/src/parquet/column/reader.cc ---------------------------------------------------------------------- diff --git a/src/parquet/column/reader.cc b/src/parquet/column/reader.cc index f79cb9d..88dc670 100644 --- a/src/parquet/column/reader.cc +++ b/src/parquet/column/reader.cc @@ -42,6 +42,8 @@ ColumnReader::ColumnReader(const ColumnDescriptor* descr, num_decoded_values_(0), allocator_(allocator) {} +ColumnReader::~ColumnReader() {} + template <typename DType> void TypedColumnReader<DType>::ConfigureDictionary(const DictionaryPage* page) { int encoding = static_cast<int>(page->encoding()); http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/ca3e697e/src/parquet/column/reader.h ---------------------------------------------------------------------- diff --git a/src/parquet/column/reader.h b/src/parquet/column/reader.h index 633f3a3..04f517c 100644 --- a/src/parquet/column/reader.h +++ b/src/parquet/column/reader.h @@ -39,6 +39,7 @@ class PARQUET_EXPORT ColumnReader { public: ColumnReader(const ColumnDescriptor*, std::unique_ptr<PageReader>, MemoryAllocator* allocator = default_allocator()); + virtual ~ColumnReader(); static std::shared_ptr<ColumnReader> Make(const ColumnDescriptor*, std::unique_ptr<PageReader>, MemoryAllocator* allocator = default_allocator()); @@ -105,6 +106,7 @@ class PARQUET_EXPORT TypedColumnReader : public ColumnReader { TypedColumnReader(const ColumnDescriptor* schema, std::unique_ptr<PageReader> pager, MemoryAllocator* allocator = default_allocator()) : ColumnReader(schema, std::move(pager), allocator), current_decoder_(NULL) {} + virtual ~TypedColumnReader() {} // Read a batch of repetition levels, definition levels, and values from the // column.
