PARQUET-726: Increase max difference of testMemoryManagerUpperLimit to 10% Author: Niels Basjes <[email protected]>
Closes #370 from nielsbasjes/PARQUET-726 and squashes the following commits: f385ede [Niels Basjes] PARQUET-726: Increase max difference of testMemoryManagerUpperLimit to 10% Project: http://git-wip-us.apache.org/repos/asf/parquet-mr/repo Commit: http://git-wip-us.apache.org/repos/asf/parquet-mr/commit/21940eef Tree: http://git-wip-us.apache.org/repos/asf/parquet-mr/tree/21940eef Diff: http://git-wip-us.apache.org/repos/asf/parquet-mr/diff/21940eef Branch: refs/heads/parquet-1.8.x Commit: 21940eef99cfb959cd1722899636e52ebece5b6f Parents: 2990dea Author: Niels Basjes <[email protected]> Authored: Wed Oct 5 13:20:41 2016 -0700 Committer: Ryan Blue <[email protected]> Committed: Mon Jan 9 16:54:54 2017 -0800 ---------------------------------------------------------------------- .../java/org/apache/parquet/hadoop/TestMemoryManager.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/21940eef/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestMemoryManager.java ---------------------------------------------------------------------- diff --git a/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestMemoryManager.java b/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestMemoryManager.java index b91fedd..3e7e3d7 100644 --- a/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestMemoryManager.java +++ b/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestMemoryManager.java @@ -68,10 +68,11 @@ public class TestMemoryManager { public void testMemoryManagerUpperLimit() { // Verify the memory pool size // this value tends to change a little between setup and tests, so this - // validates that it is within 5% of the expected value + // validates that it is within 10% of the expected value long poolSize = ParquetOutputFormat.getMemoryManager().getTotalMemoryPool(); - Assert.assertTrue("Pool size should be within 5% of the expected value", - Math.abs(expectedPoolSize - poolSize) < (long) (expectedPoolSize * 0.05)); + Assert.assertTrue("Pool size should be within 10% of the expected value" + + " (expected = " + expectedPoolSize + " actual = " + poolSize + ")", + Math.abs(expectedPoolSize - poolSize) < (long) (expectedPoolSize * 0.10)); } @Test
