This is an automated email from the ASF dual-hosted git repository.

gabor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git


The following commit(s) were added to refs/heads/master by this push:
     new 2d7b63b  PARQUET-1832: Travis fails with too long output (#777)
2d7b63b is described below

commit 2d7b63bc0ca6a8224d3a9d9a61bd4c12b0edb66d
Author: Gabor Szadovszky <[email protected]>
AuthorDate: Wed Apr 15 14:55:11 2020 +0200

    PARQUET-1832: Travis fails with too long output (#777)
---
 .travis.yml                                        |  2 +-
 .../src/main/resources/log4j.properties            |  2 +-
 parquet-format-structures/pom.xml                  |  1 +
 .../apache/parquet/statistics/TestStatistics.java  |  9 ---------
 parquet-hadoop/src/test/resources/log4j.properties |  4 ++--
 parquet-pig/src/test/resources/log4j.properties    |  2 +-
 .../src/test/resources/log4j.properties            |  2 +-
 pom.xml                                            | 23 ++++++++++++++++++++--
 8 files changed, 28 insertions(+), 17 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 77b16d9..6b56946 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -11,4 +11,4 @@ env:
   - HADOOP_PROFILE=default TEST_CODECS=gzip,snappy
 
 install: mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true 
-Dsource.skip=true | pv -fbi 60 > mvn_install.log || (cat mvn_install.log && 
false)
-script: mvn verify --batch-mode javadoc:javadoc -P $HADOOP_PROFILE
+script: mvn verify --batch-mode javadoc:javadoc -P travis,$HADOOP_PROFILE
diff --git a/parquet-benchmarks/src/main/resources/log4j.properties 
b/parquet-benchmarks/src/main/resources/log4j.properties
index f4737c8..806a6e0 100644
--- a/parquet-benchmarks/src/main/resources/log4j.properties
+++ b/parquet-benchmarks/src/main/resources/log4j.properties
@@ -16,7 +16,7 @@
 # under the License.
 #
 
-log4j.rootLogger=INFO, stdout
+log4j.rootLogger=${hadoop.logLevel}, stdout
 
 log4j.appender.stdout=org.apache.log4j.ConsoleAppender
 log4j.appender.stdout.Target=System.out
diff --git a/parquet-format-structures/pom.xml 
b/parquet-format-structures/pom.xml
index 0ccf2ae..c53d82d 100644
--- a/parquet-format-structures/pom.xml
+++ b/parquet-format-structures/pom.xml
@@ -131,6 +131,7 @@
           <!-- We have to turn off the javadoc check because thrift generates 
improper comments -->
           <doclint>none</doclint>
           <source>8</source>
+          <quiet>true</quiet>
         </configuration>
       </plugin>
     </plugins>
diff --git 
a/parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestStatistics.java
 
b/parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestStatistics.java
index 5a5d6d4..e5cd40f 100644
--- 
a/parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestStatistics.java
+++ 
b/parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestStatistics.java
@@ -299,9 +299,6 @@ public class TestStatistics {
       if (stats.isEmpty()) {
         // stats are empty if num nulls = 0 and there are no non-null values
         // this happens if stats are not written (e.g., when stats are too big)
-        System.err.println(String.format(
-            "No stats written for page=%s col=%s",
-            page, Arrays.toString(desc.getPath())));
         return;
       }
 
@@ -317,12 +314,6 @@ public class TestStatistics {
       }
 
       Assert.assertEquals(numNulls, stats.getNumNulls());
-
-      System.err.println(String.format(
-          "Validated stats min=%s max=%s nulls=%d for page=%s col=%s",
-          stats.minAsString(),
-          stats.maxAsString(), stats.getNumNulls(), page,
-          Arrays.toString(desc.getPath())));
     }
   }
 
diff --git a/parquet-hadoop/src/test/resources/log4j.properties 
b/parquet-hadoop/src/test/resources/log4j.properties
index 678fd66..126f557 100644
--- a/parquet-hadoop/src/test/resources/log4j.properties
+++ b/parquet-hadoop/src/test/resources/log4j.properties
@@ -16,9 +16,9 @@
 # specific language governing permissions and limitations
 # under the License.
 #
-log4j.rootLogger=INFO, stdout
+log4j.rootLogger=${hadoop.logLevel}, stdout
 log4j.appender.stdout=org.apache.log4j.ConsoleAppender
 log4j.appender.stdout.Target=System.out
-log4j.appender.stdout.threshold=INFO
+log4j.appender.stdout.threshold=${hadoop.logLevel}
 log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
 log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5p %30c{1}:%4L - 
%m%n
diff --git a/parquet-pig/src/test/resources/log4j.properties 
b/parquet-pig/src/test/resources/log4j.properties
index b60c8c6..63ff353 100644
--- a/parquet-pig/src/test/resources/log4j.properties
+++ b/parquet-pig/src/test/resources/log4j.properties
@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-log4j.rootCategory=INFO, console
+log4j.rootCategory=${hadoop.logLevel}, console
 
 log4j.appender.console=org.apache.log4j.ConsoleAppender
 log4j.appender.console.target=System.err
diff --git a/parquet-protobuf/src/test/resources/log4j.properties 
b/parquet-protobuf/src/test/resources/log4j.properties
index b60c8c6..63ff353 100644
--- a/parquet-protobuf/src/test/resources/log4j.properties
+++ b/parquet-protobuf/src/test/resources/log4j.properties
@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-log4j.rootCategory=INFO, console
+log4j.rootCategory=${hadoop.logLevel}, console
 
 log4j.appender.console=org.apache.log4j.ConsoleAppender
 log4j.appender.console.target=System.err
diff --git a/pom.xml b/pom.xml
index 0e443b7..91e38c6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -110,6 +110,10 @@
     <opencsv.version>2.3</opencsv.version>
     <jcommander.version>1.72</jcommander.version>
     <zstd-jni.version>1.4.0-1</zstd-jni.version>
+
+    <!-- properties for the profiles -->
+    <surefire.argLine>-Xmx512m</surefire.argLine>
+    <surefire.logLevel>INFO</surefire.logLevel>
   </properties>
 
   <modules>
@@ -179,6 +183,7 @@
             
<sourceFileExclude>**/generated-sources/**/*.java</sourceFileExclude>
           </sourceFileExcludes>
           <source>8</source>
+          <quiet>true</quiet>
         </configuration>
       </plugin>
       <plugin>
@@ -331,6 +336,7 @@
             
<sourceFileExclude>**/generated-sources/**/*.java</sourceFileExclude>
           </sourceFileExcludes>
           <source>8</source>
+          <quiet>true</quiet>
         </configuration>
       </plugin>
       <plugin>
@@ -395,16 +401,19 @@
         <artifactId>maven-surefire-plugin</artifactId>
         <version>2.10</version>
         <configuration>
-          <argLine>-Xmx512m</argLine>
+          <argLine>${surefire.argLine}</argLine>
           <systemPropertyVariables>
             <!-- Configure Parquet logging during tests
                  See http://www.slf4j.org/api/org/slf4j/impl/SimpleLogger.html
                  -->
-            
<org.slf4j.simpleLogger.defaultLogLevel>info</org.slf4j.simpleLogger.defaultLogLevel>
+            
<org.slf4j.simpleLogger.defaultLogLevel>${surefire.logLevel}</org.slf4j.simpleLogger.defaultLogLevel>
             
<org.slf4j.simpleLogger.showDateTime>true</org.slf4j.simpleLogger.showDateTime>
             <org.slf4j.simpleLogger.dateTimeFormat>YYYY-MM-dd 
HH:mm:ss</org.slf4j.simpleLogger.dateTimeFormat>
             
<org.slf4j.simpleLogger.showThreadName>false</org.slf4j.simpleLogger.showThreadName>
             
<org.slf4j.simpleLogger.showShortLogName>true</org.slf4j.simpleLogger.showShortLogName>
+
+            <!-- Configure log level for Hadoop -->
+            <hadoop.logLevel>${surefire.logLevel}</hadoop.logLevel>
           </systemPropertyVariables>
           <excludes>
             <exclude>**/benchmark/*.java</exclude>
@@ -588,5 +597,15 @@
         <thrift.version>0.9.0</thrift.version>
       </properties>
     </profile>
+
+    <!-- Profile for Travis to have less output -->
+    <profile>
+      <id>travis</id>
+      <properties>
+        <surefire.logLevel>WARN</surefire.logLevel>
+        <surefire.argLine>-Xmx512m 
-XX:MaxJavaStackTraceDepth=10</surefire.argLine>
+      </properties>
+    </profile>
+
   </profiles>
 </project>

Reply via email to