This is an automated email from the ASF dual-hosted git repository.
gabor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git
The following commit(s) were added to refs/heads/master by this push:
new b2d366a PARQUET-1863: Configure protoc-jar-maven-plugin to add
generated sources to test sources path (#792)
b2d366a is described below
commit b2d366a83f293914195f9de86d918f8ddd944374
Author: Laurent Goujon <[email protected]>
AuthorDate: Mon May 18 06:19:55 2020 -0700
PARQUET-1863: Configure protoc-jar-maven-plugin to add generated sources to
test sources path (#792)
By default, protoc-jar-maven-plugin adds generated source files into the
main sources path but it can be configured to add them to the test
sources path instead.
Change the plugin configuration to do so, and remove use of the now
obsolete build-helper-maven-plugin:add-test-source goal.
---
parquet-protobuf/pom.xml | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/parquet-protobuf/pom.xml b/parquet-protobuf/pom.xml
index 6870762..c1b58e1 100644
--- a/parquet-protobuf/pom.xml
+++ b/parquet-protobuf/pom.xml
@@ -143,27 +143,6 @@
</executions>
</plugin>
<plugin>
- <!-- Ensure that the specific classes are available during test
compile but not included in jar -->
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>build-helper-maven-plugin</artifactId>
- <version>1.8</version>
- <executions>
- <execution>
- <id>add-test-sources</id>
- <phase>generate-test-sources</phase>
- <goals>
- <goal>add-test-source</goal>
- </goals>
- <configuration>
- <sources>
-
<source>${project.build.directory}/generated-test-sources</source>
- </sources>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
- <plugin>
<groupId>com.github.os72</groupId>
<artifactId>protoc-jar-maven-plugin</artifactId>
<version>3.8.0</version>
@@ -176,6 +155,7 @@
</goals>
<configuration>
<protocVersion>${protobuf.version}</protocVersion>
+ <addSources>test</addSources>
<addProtoSources>all</addProtoSources>
<outputDirectory>${project.build.directory}/generated-test-sources/java</outputDirectory>
<inputDirectories>
