[parquet-mr] branch master updated: PARQUET-2325: Fix parquet-cli's dictionary subcommand to work with FIXED_LEN_BYTE_ARRAY (#1122)

[gangwu]

This is an automated email from the ASF dual-hosted git repository.

gangwu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git


The following commit(s) were added to refs/heads/master by this push:
     new 25539781f PARQUET-2325: Fix parquet-cli's dictionary subcommand to 
work with FIXED_LEN_BYTE_ARRAY (#1122)
25539781f is described below

commit 25539781fce23216b7b3c64f78e3b03a4d190858
Author: Kengo Seki <sek...@apache.org>
AuthorDate: Sun Jul 16 21:52:48 2023 +0900

    PARQUET-2325: Fix parquet-cli's dictionary subcommand to work with 
FIXED_LEN_BYTE_ARRAY (#1122)
---
 .../org/apache/parquet/cli/commands/ShowDictionaryCommand.java |  1 +
 .../apache/parquet/cli/commands/ShowDictionaryCommandTest.java | 10 ++++++++++
 2 files changed, 11 insertions(+)

diff --git 
a/parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java
 
b/parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java
index 5d7a6097c..f9daf6221 100644
--- 
a/parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java
+++ 
b/parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowDictionaryCommand.java
@@ -98,6 +98,7 @@ public class ShowDictionaryCommand extends BaseCommand {
     for (int i = 0; i <= dict.getMaxId(); i += 1) {
       switch(type.getPrimitiveTypeName()) {
         case BINARY:
+        case FIXED_LEN_BYTE_ARRAY:
           if (type.getLogicalTypeAnnotation() instanceof 
LogicalTypeAnnotation.StringLogicalTypeAnnotation) {
             console.info("{}: {}", String.format("%6d", i),
                     
Util.humanReadable(dict.decodeToBinary(i).toStringUsingUTF8(), 70));
diff --git 
a/parquet-cli/src/test/java/org/apache/parquet/cli/commands/ShowDictionaryCommandTest.java
 
b/parquet-cli/src/test/java/org/apache/parquet/cli/commands/ShowDictionaryCommandTest.java
index a4d796ce3..e0ca47a77 100644
--- 
a/parquet-cli/src/test/java/org/apache/parquet/cli/commands/ShowDictionaryCommandTest.java
+++ 
b/parquet-cli/src/test/java/org/apache/parquet/cli/commands/ShowDictionaryCommandTest.java
@@ -47,4 +47,14 @@ public class ShowDictionaryCommandTest extends 
ParquetFileTest {
     command.setConf(new Configuration());
     Assert.assertEquals(0, command.run());
   }
+
+  @Test
+  public void testShowDirectoryCommandForFixedLengthByteArray() throws 
IOException {
+    File file = parquetFile();
+    ShowDictionaryCommand command = new ShowDictionaryCommand(createLogger());
+    command.targets = Arrays.asList(file.getAbsolutePath());
+    command.column = FIXED_LEN_BYTE_ARRAY_FIELD;
+    command.setConf(new Configuration());
+    Assert.assertEquals(0, command.run());
+  }
 }