This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git


The following commit(s) were added to refs/heads/master by this push:
     new fa8794493 Use try-with-resources (#1145)
fa8794493 is described below

commit fa8794493efe825ddc91ba3e1a29d75d9890ac4b
Author: Fokko Driesprong <[email protected]>
AuthorDate: Fri Sep 22 12:35:49 2023 +0200

    Use try-with-resources (#1145)
---
 .../java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java    | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
 
b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
index 25c215d86..4f6c59123 100755
--- 
a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
+++ 
b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
@@ -62,9 +62,7 @@ public class ParquetMetadata {
   }
 
   private static String toJSON(ParquetMetadata parquetMetaData, boolean 
isPrettyPrint) {
-    StringWriter stringWriter = new StringWriter();
-
-    try {
+    try (StringWriter stringWriter = new StringWriter()) {
       if (isPrettyPrint) {
         Object objectToPrint;
         if (parquetMetaData.getFileMetaData() == null ||
@@ -77,10 +75,10 @@ public class ParquetMetadata {
       } else {
         objectMapper.writeValue(stringWriter, parquetMetaData);
       }
+      return stringWriter.toString();
     } catch (IOException e) {
       throw new RuntimeException(e);
     }
-    return stringWriter.toString();
   }
 
   /**

Reply via email to