(parquet-mr) branch master updated: PARQUET-2395: Prefer `singletonList` over `asList` (#1218)

[fokko]

This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git


The following commit(s) were added to refs/heads/master by this push:
     new 44b56225b PARQUET-2395: Prefer `singletonList` over `asList` (#1218)
44b56225b is described below

commit 44b56225be6fe7b74667f4f2430326ef1f076cc5
Author: Fokko Driesprong <fo...@apache.org>
AuthorDate: Mon Dec 4 08:40:21 2023 +0100

    PARQUET-2395: Prefer `singletonList` over `asList` (#1218)
    
    * PARQUET-2395: Prefer `singletonList` over `asList`
    
    * Remove unused imports
---
 .../src/main/java/org/apache/parquet/io/MessageColumnIO.java          | 3 ++-
 .../src/main/java/org/apache/parquet/schema/PrimitiveType.java        | 3 ++-
 .../src/main/java/org/apache/parquet/glob/GlobExpander.java           | 4 ++--
 parquet-common/src/main/java/org/apache/parquet/glob/GlobParser.java  | 4 ++--
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git 
a/parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java 
b/parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java
index 4433b2ae5..5f783ca97 100644
--- a/parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java
+++ b/parquet-column/src/main/java/org/apache/parquet/io/MessageColumnIO.java
@@ -23,6 +23,7 @@ import it.unimi.dsi.fastutil.ints.IntIterator;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.BitSet;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -512,7 +513,7 @@ public class MessageColumnIO extends GroupColumnIO {
   }
 
   void setLevels() {
-    setLevels(0, 0, new String[0], new int[0], Arrays.<ColumnIO>asList(this), 
Arrays.<ColumnIO>asList(this));
+    setLevels(0, 0, new String[0], new int[0], 
Collections.singletonList(this), Collections.singletonList(this));
   }
 
   void setLeaves(List<PrimitiveColumnIO> leaves) {
diff --git 
a/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java 
b/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
index 21056033a..2867d0d46 100644
--- a/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
+++ b/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
@@ -23,6 +23,7 @@ import static java.util.Optional.of;
 import static org.apache.parquet.schema.LogicalTypeAnnotation.TimeUnit.MILLIS;
 
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 import java.util.Objects;
@@ -734,7 +735,7 @@ public final class PrimitiveType extends Type {
 
   @Override
   protected List<String[]> getPaths(int depth) {
-    return Arrays.<String[]>asList(new String[depth]);
+    return Collections.singletonList(new String[depth]);
   }
 
   @Override
diff --git 
a/parquet-common/src/main/java/org/apache/parquet/glob/GlobExpander.java 
b/parquet-common/src/main/java/org/apache/parquet/glob/GlobExpander.java
index ae7ff992a..1963b3c72 100644
--- a/parquet-common/src/main/java/org/apache/parquet/glob/GlobExpander.java
+++ b/parquet-common/src/main/java/org/apache/parquet/glob/GlobExpander.java
@@ -19,7 +19,7 @@
 package org.apache.parquet.glob;
 
 import java.util.ArrayList;
-import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 import org.apache.parquet.glob.GlobNode.Atom;
 import org.apache.parquet.glob.GlobNode.GlobNodeSequence;
@@ -69,7 +69,7 @@ public final class GlobExpander {
     @Override
     public List<String> visit(Atom atom) {
       // atoms are the base case, just return a singleton list
-      return Arrays.asList(atom.get());
+      return Collections.singletonList(atom.get());
     }
 
     @Override
diff --git 
a/parquet-common/src/main/java/org/apache/parquet/glob/GlobParser.java 
b/parquet-common/src/main/java/org/apache/parquet/glob/GlobParser.java
index 5d9665cbc..10d8a7b68 100644
--- a/parquet-common/src/main/java/org/apache/parquet/glob/GlobParser.java
+++ b/parquet-common/src/main/java/org/apache/parquet/glob/GlobParser.java
@@ -19,7 +19,7 @@
 package org.apache.parquet.glob;
 
 import java.util.ArrayList;
-import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 import org.apache.parquet.glob.GlobNode.Atom;
 import org.apache.parquet.glob.GlobNode.GlobNodeSequence;
@@ -56,7 +56,7 @@ final class GlobParser {
      */
 
     if (pattern.isEmpty() || pattern.equals("{}")) {
-      return new GlobNodeSequence(Arrays.<GlobNode>asList(new Atom("")));
+      return new GlobNodeSequence(Collections.singletonList(new Atom("")));
     }
 
     // the outer parse method needs to parse the pattern into a