This is an automated email from the ASF dual-hosted git repository.
fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git
The following commit(s) were added to refs/heads/master by this push:
new f657b4302 PARQUET-2392: Remove StringBuilder in
`LogicalTypeAnnotation` (#1215)
f657b4302 is described below
commit f657b4302b981b4e5ecf716b6d696ce7294ac53f
Author: Fokko Driesprong <[email protected]>
AuthorDate: Mon Dec 4 12:01:29 2023 +0100
PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation` (#1215)
* PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation`
* Fix identation
---
.../parquet/schema/LogicalTypeAnnotation.java | 37 +++-------------------
1 file changed, 5 insertions(+), 32 deletions(-)
diff --git
a/parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
b/parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
index 85d68c182..ee09c999f 100644
---
a/parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
+++
b/parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java
@@ -176,10 +176,7 @@ public abstract class LogicalTypeAnnotation {
@Override
public String toString() {
- StringBuilder sb = new StringBuilder();
- sb.append(getType());
- sb.append(typeParametersAsString());
- return sb.toString();
+ return getType() + typeParametersAsString();
}
PrimitiveStringifier valueStringifier(PrimitiveType primitiveType) {
@@ -518,13 +515,7 @@ public abstract class LogicalTypeAnnotation {
@Override
protected String typeParametersAsString() {
- StringBuilder sb = new StringBuilder();
- sb.append("(");
- sb.append(precision);
- sb.append(",");
- sb.append(scale);
- sb.append(")");
- return sb.toString();
+ return "(" + precision + "," + scale + ")";
}
@Override
@@ -637,13 +628,7 @@ public abstract class LogicalTypeAnnotation {
@Override
protected String typeParametersAsString() {
- StringBuilder sb = new StringBuilder();
- sb.append("(");
- sb.append(unit);
- sb.append(",");
- sb.append(isAdjustedToUTC);
- sb.append(")");
- return sb.toString();
+ return "(" + unit + "," + isAdjustedToUTC + ")";
}
public TimeUnit getUnit() {
@@ -722,13 +707,7 @@ public abstract class LogicalTypeAnnotation {
@Override
protected String typeParametersAsString() {
- StringBuilder sb = new StringBuilder();
- sb.append("(");
- sb.append(unit);
- sb.append(",");
- sb.append(isAdjustedToUTC);
- sb.append(")");
- return sb.toString();
+ return "(" + unit + "," + isAdjustedToUTC + ")";
}
public TimeUnit getUnit() {
@@ -818,13 +797,7 @@ public abstract class LogicalTypeAnnotation {
@Override
protected String typeParametersAsString() {
- StringBuilder sb = new StringBuilder();
- sb.append("(");
- sb.append(bitWidth);
- sb.append(",");
- sb.append(isSigned);
- sb.append(")");
- return sb.toString();
+ return "(" + bitWidth + "," + isSigned + ")";
}
public int getBitWidth() {
