amousavigourabi commented on code in PR #1221:
URL: https://github.com/apache/parquet-mr/pull/1221#discussion_r1415515299
##########
pom.xml:
##########
@@ -596,6 +596,8 @@
<!-- Due to the removal of deprecated methods -->
<exclude>org.apache.parquet.arrow.schema.SchemaMapping</exclude>
+
+
<exclude>org.apache.parquet.hadoop.ParquetFileReader.PARQUET_READ_PARALLELISM</exclude>
Review Comment:
```suggestion
<!-- Make static variables final -->
<exclude>org.apache.parquet.avro.AvroReadSupport#AVRO_REQUESTED_PROJECTION</exclude>
<exclude>org.apache.parquet.avro.AvroReadSupport#AVRO_DATA_SUPPLIER</exclude>
<exclude>org.apache.parquet.hadoop.ParquetFileReader#PARQUET_READ_PARALLELISM</exclude>
```
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java:
##########
@@ -44,16 +44,15 @@ public class AvroReadSupport<T> extends ReadSupport<T> {
private static final Logger LOG =
LoggerFactory.getLogger(AvroReadSupport.class);
- public static String AVRO_REQUESTED_PROJECTION = "parquet.avro.projection";
+ public static final String AVRO_REQUESTED_PROJECTION =
"parquet.avro.projection";
Review Comment:
All of these newly `final` fields should be excluded by the japicmp
configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
