clairemcginty commented on code in PR #1328:
URL: https://github.com/apache/parquet-java/pull/1328#discussion_r1608679199
##########
parquet-column/src/main/java/org/apache/parquet/filter2/predicate/FilterApi.java:
##########
@@ -257,6 +258,10 @@ public static <T extends Comparable<T>, C extends
Column<T> & SupportsEqNotEq> N
return new NotIn<>(column, values);
}
+ public static <T extends Comparable<T>> Contains<T> contains(Eq<T> pred) {
Review Comment:
In a fast-follow-up PR we can just replace this signature with:
```java
public static <T extends Comparable<T>> Contains<T>
contains(ColumnFilterPredicate<T> pred) {
...
}
```
and remove the `SupportsContains` annotation. I did a few tests of
`Contains(lt)` and `Contains(gt)` and everything is working as expected 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
