This is an automated email from the ASF dual-hosted git repository.
fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-java.git
The following commit(s) were added to refs/heads/master by this push:
new 1c76796da GH-2921: Remove Jackson JDK8 module (#1378)
1c76796da is described below
commit 1c76796da5d0f34e349da52bb609aa98b7bcb91e
Author: Fokko Driesprong <[email protected]>
AuthorDate: Tue Jul 30 08:05:38 2024 +0200
GH-2921: Remove Jackson JDK8 module (#1378)
* PARQUET-2501: Remove Jackson JDK8 module
Not needed anymore :)
* Revert spotless
---
parquet-hadoop/pom.xml | 5 -----
.../org/apache/parquet/hadoop/metadata/ParquetMetadata.java | 12 +-----------
parquet-jackson/pom.xml | 6 ------
pom.xml | 1 -
4 files changed, 1 insertion(+), 23 deletions(-)
diff --git a/parquet-hadoop/pom.xml b/parquet-hadoop/pom.xml
index d12948317..ce023b518 100644
--- a/parquet-hadoop/pom.xml
+++ b/parquet-hadoop/pom.xml
@@ -128,11 +128,6 @@
<artifactId>jackson-databind</artifactId>
<version>${jackson-databind.version}</version>
</dependency>
- <dependency>
- <groupId>${jackson.datatype.groupId}</groupId>
- <artifactId>jackson-datatype-jdk8</artifactId>
- <version>${jackson-modules-java8.version}</version>
- </dependency>
<dependency>
<groupId>org.xerial.snappy</groupId>
<artifactId>snappy-java</artifactId>
diff --git
a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
index 640ecfba1..1709303a9 100755
---
a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
+++
b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
@@ -20,29 +20,19 @@ package org.apache.parquet.hadoop.metadata;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.ObjectWriter;
-import com.fasterxml.jackson.databind.SerializationFeature;
-import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
import java.io.IOException;
import java.io.StringReader;
import java.io.StringWriter;
import java.util.List;
/**
- * Meta Data block stored in the footer of the file
+ * Metadata block stored in the footer of the file
* contains file level (Codec, Schema, ...) and block level (location,
columns, record count, ...) meta data
*/
public class ParquetMetadata {
private static final ObjectMapper objectMapper = new ObjectMapper();
- static {
- // Enable FAIL_ON_EMPTY_BEANS on objectmapper. Without this feature
parquet-casdacing tests fail,
- // because LogicalTypeAnnotation implementations are classes without any
property.
- objectMapper.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
- // Add support for Java 8 Optional
- objectMapper.registerModule(new Jdk8Module());
- }
-
/**
* @param parquetMetaData an instance of parquet metadata to convert
* @return the json representation
diff --git a/parquet-jackson/pom.xml b/parquet-jackson/pom.xml
index 23ee80fbd..9f71898ae 100644
--- a/parquet-jackson/pom.xml
+++ b/parquet-jackson/pom.xml
@@ -48,12 +48,6 @@
<artifactId>jackson-databind</artifactId>
<version>${jackson-databind.version}</version>
</dependency>
- <!-- Add support for Java 8 Optional -->
- <dependency>
- <groupId>com.fasterxml.jackson.datatype</groupId>
- <artifactId>jackson-datatype-jdk8</artifactId>
- <version>${jackson-modules-java8.version}</version>
- </dependency>
</dependencies>
<properties>
diff --git a/pom.xml b/pom.xml
index db30a31cf..5a488e294 100644
--- a/pom.xml
+++ b/pom.xml
@@ -69,7 +69,6 @@
<jackson.package>com.fasterxml.jackson</jackson.package>
<jackson.version>2.17.1</jackson.version>
<jackson-databind.version>2.17.1</jackson-databind.version>
- <jackson-modules-java8.version>2.17.1</jackson-modules-java8.version>
<japicmp.version>0.21.0</japicmp.version>
<javax.annotation.version>1.3.2</javax.annotation.version>
<spotless.version>2.30.0</spotless.version>
