Fokko commented on code in PR #100:
URL: https://github.com/apache/parquet-site/pull/100#discussion_r1944303748


##########
content/en/docs/File Format/implementationstatus.md:
##########
@@ -45,64 +45,64 @@ Implementations:
 
 | Data type                                 | C++   | Java  | Go    | Rust  | 
cuDF  |
 | ----------------------------------------- | ----- | ----- | ----- | ----- | 
----- |
-| STRING                                    |       |       |       |       |  
✅   |
-| ENUM                                      |       |       |       |       |  
❌   |
-| UUID                                      |       |       |       |       |  
❌   |
-| 8, 16, 32, 64 bit signed and unsigned INT |       |       |       |       |  
✅   |
-| DECIMAL (INT32)                           |       |       |       |       |  
✅   |
-| DECIMAL (INT64)                           |       |       |       |       |  
✅   |
-| DECIMAL (BYTE_ARRAY)                      |       |       |       |       |  
✅   |
-| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |       |       |       |       |  
✅   |
-| DATE                                      |       |       |       |       |  
✅   |
-| TIME (INT32)                              |       |       |       |       |  
✅   |
-| TIME (INT64)                              |       |       |       |       |  
✅   |
-| TIMESTAMP (INT64)                         |       |       |       |       |  
✅   |
-| INTERVAL                                  |       |       |       |       |  
❌   |
-| JSON                                      |       |       |       |       |  
❌   |
-| BSON                                      |       |       |       |       |  
❌   |
-| LIST                                      |       |       |       |       |  
✅   |
-| MAP                                       |       |       |       |       |  
✅   |
-| UNKNOWN (always null)                     |       |       |       |       |  
✅   |
-| FLOAT16                                   |       |       |       |       |  
✅   |
+| STRING                                    |  ✅   |  ✅   |       |       |  ✅ 
  |
+| ENUM                                      |  ❌   |  ✅   |       |       |  ❌ 
  |
+| UUID                                      |  ❌   |  ✅   |       |       |  ❌ 
  |
+| 8, 16, 32, 64 bit signed and unsigned INT |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (INT32)                           |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (INT64)                           |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (BYTE_ARRAY)                      |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DATE                                      |  ✅   |  ✅   |       |       |  ✅ 
  |
+| TIME (INT32)                              |  ✅   |  ✅   |       |       |  ✅ 
  |
+| TIME (INT64)                              |  ✅   |  ✅   |       |       |  ✅ 
  |
+| TIMESTAMP (INT64)                         |  ✅   |  ✅   |       |       |  ✅ 
  |
+| INTERVAL                                  |  ✅   |  ❌   |       |       |  ❌ 
  |
+| JSON                                      |  ✅   |  ✅   |       |       |  ❌ 
  |
+| BSON                                      |  ❌   |  ❌   |       |       |  ❌ 
  |
+| LIST                                      |  ✅   |  ✅   |       |       |  ✅ 
  |
+| MAP                                       |  ✅   |  ✅   |       |       |  ✅ 
  |
+| UNKNOWN (always null)                     |  ✅   |  ✅   |       |       |  ✅ 
  |

Review Comment:
   We don't have this one explicitly
   ```suggestion
   | UNKNOWN (always null)                     |  ✅   |  ❌   |       |       |  
✅   |
   ```



##########
content/en/docs/File Format/implementationstatus.md:
##########
@@ -45,64 +45,64 @@ Implementations:
 
 | Data type                                 | C++   | Java  | Go    | Rust  | 
cuDF  |
 | ----------------------------------------- | ----- | ----- | ----- | ----- | 
----- |
-| STRING                                    |       |       |       |       |  
✅   |
-| ENUM                                      |       |       |       |       |  
❌   |
-| UUID                                      |       |       |       |       |  
❌   |
-| 8, 16, 32, 64 bit signed and unsigned INT |       |       |       |       |  
✅   |
-| DECIMAL (INT32)                           |       |       |       |       |  
✅   |
-| DECIMAL (INT64)                           |       |       |       |       |  
✅   |
-| DECIMAL (BYTE_ARRAY)                      |       |       |       |       |  
✅   |
-| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |       |       |       |       |  
✅   |
-| DATE                                      |       |       |       |       |  
✅   |
-| TIME (INT32)                              |       |       |       |       |  
✅   |
-| TIME (INT64)                              |       |       |       |       |  
✅   |
-| TIMESTAMP (INT64)                         |       |       |       |       |  
✅   |
-| INTERVAL                                  |       |       |       |       |  
❌   |
-| JSON                                      |       |       |       |       |  
❌   |
-| BSON                                      |       |       |       |       |  
❌   |
-| LIST                                      |       |       |       |       |  
✅   |
-| MAP                                       |       |       |       |       |  
✅   |
-| UNKNOWN (always null)                     |       |       |       |       |  
✅   |
-| FLOAT16                                   |       |       |       |       |  
✅   |
+| STRING                                    |  ✅   |  ✅   |       |       |  ✅ 
  |
+| ENUM                                      |  ❌   |  ✅   |       |       |  ❌ 
  |
+| UUID                                      |  ❌   |  ✅   |       |       |  ❌ 
  |
+| 8, 16, 32, 64 bit signed and unsigned INT |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (INT32)                           |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (INT64)                           |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (BYTE_ARRAY)                      |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |  ✅   |  ✅   |       |       |  ✅ 
  |
+| DATE                                      |  ✅   |  ✅   |       |       |  ✅ 
  |
+| TIME (INT32)                              |  ✅   |  ✅   |       |       |  ✅ 
  |
+| TIME (INT64)                              |  ✅   |  ✅   |       |       |  ✅ 
  |
+| TIMESTAMP (INT64)                         |  ✅   |  ✅   |       |       |  ✅ 
  |

Review Comment:
   Should we split this out on the unit as well?
   ```suggestion
   | TIMESTAMP (INT64, MICROS)                 |  ✅   |  ✅   |       |       |  
✅   |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to