etseidl commented on code in PR #101:
URL: https://github.com/apache/parquet-site/pull/101#discussion_r1955065906


##########
content/en/docs/File Format/implementationstatus.md:
##########
@@ -45,66 +45,66 @@ Implementations:
 
 | Data type                                 | C++   | Java  | Go    | Rust  | 
cuDF  |
 | ----------------------------------------- | ----- | ----- | ----- | ----- | 
----- |
-| STRING                                    |  ✅   |  ✅   |       |       |  ✅ 
  |
-| ENUM                                      |  ❌   |  ✅   |       |       |  ❌ 
  |
-| UUID                                      |  ❌   |  ✅   |       |       |  ❌ 
  |
-| 8, 16, 32, 64 bit signed and unsigned INT |  ✅   |  ✅   |       |       |  ✅ 
  |
-| DECIMAL (INT32)                           |  ✅   |  ✅   |       |       |  ✅ 
  |
-| DECIMAL (INT64)                           |  ✅   |  ✅   |       |       |  ✅ 
  |
-| DECIMAL (BYTE_ARRAY)                      |  ✅   |  ✅   |       |       |  ✅ 
  |
-| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |  ✅   |  ✅   |       |       |  ✅ 
  |
-| DATE                                      |  ✅   |  ✅   |       |       |  ✅ 
  |
-| TIME (INT32)                              |  ✅   |  ✅   |       |       |  ✅ 
  |
-| TIME (INT64)                              |  ✅   |  ✅   |       |       |  ✅ 
  |
-| TIMESTAMP (INT64)                         |  ✅   |  ✅   |       |       |  ✅ 
  |
-| INTERVAL                                  |  ✅   |  ✅(*)|       |       |  ❌ 
  |
-| JSON                                      |  ✅   |  ✅(*)|       |       |  ❌ 
  |
-| BSON                                      |  ❌   |  ✅(*)|       |       |  ❌ 
  |
-| LIST                                      |  ✅   |  ✅   |       |       |  ✅ 
  |
-| MAP                                       |  ✅   |  ✅   |       |       |  ✅ 
  |
-| UNKNOWN (always null)                     |  ✅   |  ✅   |       |       |  ✅ 
  |
-| FLOAT16                                   |  ✅   |  ✅(*)|       |       |  ✅ 
  |
+| STRING                                    |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| ENUM                                      |  ❌   |  ✅   |       |  ✅(*)|  ❌  
 |
+| UUID                                      |  ❌   |  ✅   |       |  ✅(*)|  ❌  
 |
+| 8, 16, 32, 64 bit signed and unsigned INT |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| DECIMAL (INT32)                           |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| DECIMAL (INT64)                           |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| DECIMAL (BYTE_ARRAY)                      |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| DATE                                      |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| TIME (INT32)                              |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| TIME (INT64)                              |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| TIMESTAMP (INT64)                         |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| INTERVAL                                  |  ✅   |  ✅(*)|       |  ✅   |  ❌  
 |
+| JSON                                      |  ✅   |  ✅(*)|       |  ✅(*)|  ❌  
 |
+| BSON                                      |  ❌   |  ✅(*)|       |  ✅(*)|  ❌  
 |
+| LIST                                      |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| MAP                                       |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| UNKNOWN (always null)                     |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| FLOAT16                                   |  ✅   |  ✅(*)|       |  ✅   |  ✅  
 |
 
 (*): Only supported to use its annotated physical type
 
 ### Encodings
 
 | Encoding                                  | C++   | Java  | Go    | Rust  | 
cuDF  |
 | ----------------------------------------- | ----- | ----- | ----- | ----- | 
----- |
-| PLAIN                                     |  ✅   |  ✅   |       |       |  ✅ 
  |
-| PLAIN_DICTIONARY                          |  ✅   |  ✅   |       |       |  ✅ 
  |
-| RLE_DICTIONARY                            |  ✅   |  ✅   |       |       |  ✅ 
  |
-| RLE                                       |  ✅   |  ✅   |       |       |  ✅ 
  |
-| BIT_PACKED (deprecated)                   |  ✅   |  ✅   |       |       |  
(R)  |
-| DELTA_BINARY_PACKED                       |  ✅   |  ✅   |       |       |  ✅ 
  |
-| DELTA_LENGTH_BYTE_ARRAY                   |  ✅   |  ✅   |       |       |  ✅ 
  |
-| DELTA_BYTE_ARRAY                          |  ✅   |  ✅   |       |       |  ✅ 
  |
-| BYTE_STREAM_SPLIT                         |  ✅   |  ✅   |       |       |  ✅ 
  |
+| PLAIN                                     |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| PLAIN_DICTIONARY                          |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| RLE_DICTIONARY                            |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| RLE                                       |  ✅   |  ✅   |       |  ✅   |  ✅  
 |
+| BIT_PACKED (deprecated)                   |  ✅   |  ✅   |       |  ❌   |  
(R)  |

Review Comment:
   > If I remember correctly, Java might use the encoding if the bitwidth is 0, 
in that case the different bit order does not matter since there is no actual 
data is written.
   
   Yes, I recall seeing files that indicated BIT_PACKED encoding was used, but 
as you said it was for `max level == 0` (thus `bitwidth == 0`), so in other 
words, no data is actually present/encoded.
   
   I'll add a note to that effect. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to