This is an automated email from the ASF dual-hosted git repository.
gangwu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-java.git
The following commit(s) were added to refs/heads/master by this push:
new 6a5d0d0db GH-3312: Support uuid read converter for parquet thrift
(#3313)
6a5d0d0db is described below
commit 6a5d0d0db5b94295a64476173de0f03c7be59860
Author: Arnav Balyan <[email protected]>
AuthorDate: Wed Sep 24 11:57:56 2025 +0530
GH-3312: Support uuid read converter for parquet thrift (#3313)
---
.../parquet/thrift/ThriftRecordConverter.java | 21 ++++++++
.../thrift/TestUUIDRecordConverterFailure.java | 61 ++++++++++++++++++++++
2 files changed, 82 insertions(+)
diff --git
a/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftRecordConverter.java
b/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftRecordConverter.java
index d86936cb3..edfc434d7 100644
---
a/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftRecordConverter.java
+++
b/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftRecordConverter.java
@@ -412,6 +412,25 @@ public class ThriftRecordConverter<T> extends
RecordMaterializer<T> {
/**
* converts Binary into Enum
*/
+ static class FieldUUIDConverter extends PrimitiveConverter {
+
+ private final List<TProtocol> events;
+
+ public FieldUUIDConverter(List<TProtocol> events, ThriftField field) {
+ this.events = events;
+ }
+
+ @Override
+ public void addBinary(final Binary value) {
+ events.add(new ParquetProtocol("readBinary() uuid") {
+ @Override
+ public ByteBuffer readBinary() throws TException {
+ return ByteBuffer.wrap(value.getBytes());
+ }
+ });
+ }
+ }
+
static class FieldEnumConverter extends PrimitiveConverter {
private final List<TProtocol> events;
@@ -960,6 +979,8 @@ public class ThriftRecordConverter<T> extends
RecordMaterializer<T> {
return new FieldStringConverter(events, field);
case ENUM:
return new FieldEnumConverter(events, field);
+ case UUID:
+ return new FieldUUIDConverter(events, field);
default:
return new FieldPrimitiveConverter(events, field);
}
diff --git
a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestUUIDRecordConverterFailure.java
b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestUUIDRecordConverterFailure.java
new file mode 100644
index 000000000..e7010d7b6
--- /dev/null
+++
b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestUUIDRecordConverterFailure.java
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.parquet.thrift;
+
+import static org.junit.Assert.*;
+
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.UUID;
+import org.apache.parquet.io.api.Binary;
+import org.apache.parquet.thrift.struct.ThriftField;
+import org.apache.parquet.thrift.struct.ThriftType;
+import org.apache.thrift.protocol.TProtocol;
+import org.junit.Test;
+
+// Test to verify UUID converter support in ThriftRecordConverter.
+public class TestUUIDRecordConverterFailure {
+
+ @Test
+ public void testUUIDConverterSupport() {
+ ThriftType.UUIDType uuidType = new ThriftType.UUIDType();
+ ThriftField uuidField = new ThriftField("id", (short) 1,
ThriftField.Requirement.REQUIRED, uuidType);
+
+ UUID testUUID = UUID.fromString("550e8400-e29b-41d4-a716-446655440000");
+ byte[] uuidBytes = uuidToBytes(testUUID);
+ Binary binary = Binary.fromConstantByteArray(uuidBytes);
+
+ ThriftRecordConverter.FieldUUIDConverter uuidConverter =
+ new ThriftRecordConverter.FieldUUIDConverter(new
ArrayList<TProtocol>(), uuidField);
+
+ try {
+ uuidConverter.addBinary(binary);
+ assertTrue("UUID converter handled binary data", true);
+ } catch (UnsupportedOperationException e) {
+ fail("UUID converter should handle binary data, but got: " +
e.getMessage());
+ }
+ }
+
+ private byte[] uuidToBytes(UUID uuid) {
+ ByteBuffer buffer = ByteBuffer.allocate(16);
+ buffer.putLong(uuid.getMostSignificantBits());
+ buffer.putLong(uuid.getLeastSignificantBits());
+ return buffer.array();
+ }
+}
