paleolimbot commented on code in PR #123:
URL: https://github.com/apache/parquet-site/pull/123#discussion_r2455434022


##########
content/en/docs/File Format/implementationstatus.md:
##########
@@ -43,30 +49,43 @@ Implementations:
 
 ### Logical types
 
-| Data type                                 | arrow | parquet-java  | arrow-go 
| arrow-rs | cudf  | hyparquet | duckdb |
-| ----------------------------------------- | ----- | ------------- | -------- 
| -------- | ----- | --------- | ------ |
-| STRING                                    |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| ENUM                                      |  ❌   |  ✅           |  ✅      |  
✅ (1)  |  ❌   |  ✅       |   ✅   |
-| UUID                                      |  ❌   |  ✅           |  ✅      |  
✅ (1)  |  ❌   |  ✅       |   ✅   |
-| 8, 16, 32, 64 bit signed and unsigned INT |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DECIMAL (INT32)                           |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DECIMAL (INT64)                           |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DECIMAL (BYTE_ARRAY)                      |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   (R)  |
-| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DATE                                      |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| TIME (INT32)                              |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| TIME (INT64)                              |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| TIMESTAMP (INT64)                         |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| INTERVAL                                  |  ✅   |  ✅ (1)       |  ✅      |  
✅      |  ❌   |  ✅       |   ✅   |
-| JSON                                      |  ✅   |  ✅ (1)       |  ✅      |  
✅ (1)  |  ❌   |  ✅       |   ✅   |
-| BSON                                      |  ❌   |  ✅ (1)       |  ✅      |  
✅ (1)  |  ❌   |  ❌       |   ❌   |
-| LIST                                      |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  (R)      |   ✅   |
-| MAP                                       |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  (R)      |   ✅   |
-| UNKNOWN (always null)                     |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| FLOAT16                                   |  ✅   |  ✅ (1)       |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
+Logical types are defined by the [`union LogicalType` in parquet.thrift] and 
described in [LogicalTypes.md]
+
+[`union LogicalType` in parquet.thrift]: 
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L471
+[LogicalTypes.md]: 
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md
+
+| Data type                               | arrow | parquet-java | arrow-go | 
arrow-rs | cudf | hyparquet | duckdb |
+|-----------------------------------------|------| ------- | ------- | ------- 
| ---- | -------- |--------|
+| STRING                                  | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| ENUM                                    | ❌    |  ✅     |  ✅     |  ✅ (1) |  
❌  |  ✅      | ✅      |
+| UUID                                    | ❌    |  ✅     |  ✅     |  ✅ (1) |  
❌  |  ✅      | ✅      |
+| 8, 16, 32, 64 bit signed and unsigned INT | ✅    |  ✅     |  ✅     |  ✅     
|  ✅  |  ✅      | ✅      |
+| DECIMAL (INT32)                         | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| DECIMAL (INT64)                         | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| DECIMAL (BYTE_ARRAY)                    | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | (R)    |
+| DECIMAL (FIXED_LEN_BYTE_ARRAY)          | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| FLOAT16                                 | ✅    |  ✅ (1) |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| DATE                                    | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| TIME (INT32)                            | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| TIME (INT64)                            | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| TIMESTAMP (INT64)                       | ✅    |  ✅     |  ✅     |  ✅     |  
✅  |  ✅      | ✅      |
+| INTERVAL                                | ✅    |  ✅ (1) |  ✅     |  ✅     |  
❌  |  ✅      | ✅      |
+| JSON                                    | ✅    |  ✅ (1) |  ✅     |  ✅ (1) |  
❌  |  ✅      | ✅      |
+| BSON                                    | ❌    |  ✅ (1) |  ✅     |  ✅ (1) |  
❌  |  ❌      | ❌      |
+| [VARIANT]                               |      |        |        |        |  
   |         |        |
+| [GEOMETRY]                              |      |        |        |        |  
   |         |        |
+| [GEOGRAPHY]                             |      |        |        |        |  
   |         |        |

Review Comment:
   My mental ASCII interpolation might be off but I believe that geometry is 
supported by everything except arrow-go and cudf (read support only for 
hyparquet); and geography is supported by everything except cudf and duckdb 
(read support only for hyparquet). In arrow-rs you currently have to try pretty 
hard to actually get the types to be written or read but it's tested and can be 
done.
   
   ```suggestion
   | [GEOMETRY]                              | ✅     | ✅       |        | ✅     
  |     | (R)        | ✅       |
   | [GEOGRAPHY]                             | ✅     | ✅       |        | ✅     
  |     | (R)        |        |
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to