alamb commented on code in PR #123:
URL: https://github.com/apache/parquet-site/pull/123#discussion_r2469060564


##########
content/en/docs/File Format/implementationstatus.md:
##########
@@ -43,30 +49,43 @@ Implementations:
 
 ### Logical types
 
-| Data type                                 | arrow | parquet-java  | arrow-go 
| arrow-rs | cudf  | hyparquet | duckdb |
-| ----------------------------------------- | ----- | ------------- | -------- 
| -------- | ----- | --------- | ------ |
-| STRING                                    |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| ENUM                                      |  ❌   |  ✅           |  ✅      |  
✅ (1)  |  ❌   |  ✅       |   ✅   |
-| UUID                                      |  ❌   |  ✅           |  ✅      |  
✅ (1)  |  ❌   |  ✅       |   ✅   |
-| 8, 16, 32, 64 bit signed and unsigned INT |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DECIMAL (INT32)                           |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DECIMAL (INT64)                           |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DECIMAL (BYTE_ARRAY)                      |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   (R)  |
-| DECIMAL (FIXED_LEN_BYTE_ARRAY)            |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| DATE                                      |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| TIME (INT32)                              |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| TIME (INT64)                              |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| TIMESTAMP (INT64)                         |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| INTERVAL                                  |  ✅   |  ✅ (1)       |  ✅      |  
✅      |  ❌   |  ✅       |   ✅   |
-| JSON                                      |  ✅   |  ✅ (1)       |  ✅      |  
✅ (1)  |  ❌   |  ✅       |   ✅   |
-| BSON                                      |  ❌   |  ✅ (1)       |  ✅      |  
✅ (1)  |  ❌   |  ❌       |   ❌   |
-| LIST                                      |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  (R)      |   ✅   |
-| MAP                                       |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  (R)      |   ✅   |
-| UNKNOWN (always null)                     |  ✅   |  ✅           |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
-| FLOAT16                                   |  ✅   |  ✅ (1)       |  ✅      |  
✅      |  ✅   |  ✅       |   ✅   |
+Logical types are defined by the [`union LogicalType` in parquet.thrift] and 
described in [LogicalTypes.md]
+
+[`union LogicalType` in parquet.thrift]: 
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L471
+[LogicalTypes.md]: 
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md
+
+| Data type                               | arrow | parquet-java | arrow-go | 
arrow-rs | cudf | hyparquet | duckdb |
+|-----------------------------------------|------| ------------- | ------- | 
--------- | ---- | -------- |--------|
+| STRING                                  | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| ENUM                                    | ❌    |  ✅          |  ✅     |  ✅ 
(1)   |  ❌  |  ✅      | ✅      |
+| UUID                                    | ❌    |  ✅          |  ✅     |  ✅ 
(1)   |  ❌  |  ✅      | ✅      |
+| 8, 16, 32, 64 bit signed and unsigned INT | ✅  |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| DECIMAL (INT32)                         | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| DECIMAL (INT64)                         | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| DECIMAL (BYTE_ARRAY)                    | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | (R)    |
+| DECIMAL (FIXED_LEN_BYTE_ARRAY)          | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| FLOAT16                                 | ✅    |  ✅ (1)      |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| DATE                                    | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| TIME (INT32)                            | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| TIME (INT64)                            | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| TIMESTAMP (INT64)                       | ✅    |  ✅          |  ✅     |  ✅   
    |  ✅  |  ✅      | ✅      |
+| INTERVAL                                | ✅    |  ✅ (1)      |  ✅     |  ✅   
    |  ❌  |  ✅      | ✅      |
+| JSON                                    | ✅    |  ✅ (1)      |  ✅     |  ✅ 
(1)   |  ❌  |  ✅      | ✅      |
+| BSON                                    | ❌    |  ✅ (1)      |  ✅     |  ✅ 
(1)   |  ❌  |  ❌      | ❌      |

Review Comment:
   @neilechao and @aihuaxu I am working to characterize the support for Variant 
across readers. The arrow version says:
   
   
https://github.com/apache/arrow/blob/57f626189326251c8144d4fad89c28220c68ca75/cpp/src/parquet/arrow/variant_internal.h#L33
   
   > EXPERIMENTAL: Variant is not yet fully supported.
   
   However, looking around at the open issues in arrow 
https://github.com/apache/arrow/issues?q=is%3Aissue%20%20variant
   
   It wasn't clear to me what the current status is (should arrow have a green 
✅ or an ❌ or something else?)
   
   Some relevant PRs;
   - https://github.com/apache/arrow/issues/47838
   - https://github.com/apache/arrow/pull/45375
   - https://github.com/apache/arrow/pull/47835



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to