This is an automated email from the ASF dual-hosted git repository.
fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-java.git
The following commit(s) were added to refs/heads/master by this push:
new 6b2940ca1 Remove unused parquet-thrift dependencies (#3323)
6b2940ca1 is described below
commit 6b2940ca1f39e0073d798dfaf7724bc43950a524
Author: Aaron Niskode-Dossett <[email protected]>
AuthorDate: Fri Dec 5 15:06:08 2025 -0600
Remove unused parquet-thrift dependencies (#3323)
* Remove unused parquet-thrift dependencies
* Add back an implicit dependency; add comments
* fix scope
---
parquet-thrift/pom.xml | 40 ++++++++++------------------------------
1 file changed, 10 insertions(+), 30 deletions(-)
diff --git a/parquet-thrift/pom.xml b/parquet-thrift/pom.xml
index 15a31b43c..ade1ec3cd 100644
--- a/parquet-thrift/pom.xml
+++ b/parquet-thrift/pom.xml
@@ -52,6 +52,8 @@
<artifactId>parquet-common</artifactId>
<version>${project.version}</version>
</dependency>
+ <!-- Several of these hadoop dependencies will show up as "unused" in
dependnency analysis
+ but they are needed at runtime for several tests -->
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
@@ -67,6 +69,14 @@
<artifactId>hadoop-common</artifactId>
<scope>provided</scope>
</dependency>
+ <!-- Guava is a dependency of hadoop-common, but scoped to compile. We
need to
+ explicity declare it as a test dependency. -->
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>${guava.version}</version>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>com.twitter.elephantbird</groupId>
<artifactId>elephant-bird-core</artifactId>
@@ -107,12 +117,6 @@
<artifactId>jackson-annotations</artifactId>
<version>${jackson.version}</version>
</dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <version>${guava.version}</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.apache.parquet</groupId>
<artifactId>parquet-column</artifactId>
@@ -132,17 +136,6 @@
<classifier>${pig.classifier}</classifier>
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>javax.annotation</groupId>
- <artifactId>javax.annotation-api</artifactId>
- <version>${javax.annotation.version}</version>
- </dependency>
- <dependency> <!-- for pig runtime in tests -->
- <groupId>org.antlr</groupId>
- <artifactId>antlr-runtime</artifactId>
- <version>3.5.3</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.apache.thrift</groupId>
<artifactId>libthrift</artifactId>
@@ -154,19 +147,6 @@
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
</dependency>
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-simple</artifactId>
- <version>${slf4j.version}</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <!-- needed for Pig tests -->
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
- <version>1.2.17</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.apache.parquet</groupId>
<artifactId>parquet-hadoop</artifactId>
