alamb commented on code in PR #165:
URL: https://github.com/apache/parquet-site/pull/165#discussion_r2804866491
##########
layouts/partials/head.html:
##########
@@ -0,0 +1,43 @@
+{{/* cSpell:ignore docsearch opengraph outputformat */ -}}
Review Comment:
Can we add some comments to this file explaining what it does / is used for?
##########
layouts/partials/scripts.html:
##########
@@ -0,0 +1,74 @@
+{{ $needKaTeX := or .Params.math .Site.Params.katex.enable .Params.chem
.Site.Params.chem (.Page.Store.Get "hasKaTeX") (.Page.Store.Get "hasmhchem") -}}
+{{ $needmhchem := or .Params.chem .Site.Params.katex.mhchem.enable
(.Page.Store.Get "hasmhchem") -}}
+
+{{ if .Site.Params.markmap.enable -}}
+<style>
+.markmap > svg {
+ width: 100%;
+ height: 300px;
+}
+</style>
+<script>
+window.markmap = {
+ autoLoader: {
+ manual: true,
+ onReady() {
+ const { autoLoader, builtInPlugins } = window.markmap;
+ autoLoader.transformPlugins = builtInPlugins.filter(plugin =>
plugin.name !== 'prism');
+ },
+ },
+};
+</script>
+<script src="https://cdn.jsdelivr.net/npm/markmap-autoloader";></script>
Review Comment:
Do we also need to vendor this URL?
##########
hugo.toml:
##########
@@ -103,18 +103,15 @@ github_branch = "production"
# gcs_engine_id = "7e3f91e3eadecceaa"
# Enable Lunr.js offline search
-offlineSearch = false
+offlineSearch = true
Review Comment:
How does the Lunr.js search work? I loaded this page locally and it seems
like it still tries to use algolia
<img width="1258" height="1349" alt="Image"
src="https://github.com/user-attachments/assets/05d909d7-2414-4a3c-af7b-dad04a519238";
/>
<img width="936" height="441" alt="Image"
src="https://github.com/user-attachments/assets/45a83b31-5dac-4544-bd5e-49ba7a8eaaed";
/>
##########
assets/scss/_variables_project.scss:
##########
@@ -4,4 +4,7 @@ Add styles or override variables from the theme here.
*/
-$primary: #56a4ed
+$primary: #56a4ed;
+
+// Disable Google Fonts to comply with apache.org Content Security Policy
Review Comment:
Maybe we can create a separate PR just for this change
##########
assets/scss/_variables_project.scss:
##########
@@ -4,4 +4,7 @@ Add styles or override variables from the theme here.
*/
-$primary: #56a4ed
+$primary: #56a4ed;
+
+// Disable Google Fonts to comply with apache.org Content Security Policy
Review Comment:
👍
##########
static/js/jquery-3.7.1.min.js:
##########
@@ -0,0 +1,2 @@
+/*! jQuery v3.7.1 | (c) OpenJS Foundation and other contributors |
jquery.org/license */
Review Comment:
I do wonder why we need jquery -- the current site looks ok without it 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
