svn commit: r1592153 - in /pdfbox/trunk: fontbox/src/main/java/org/apache/fontbox/ttf/ pdfbox/src/main/java/org/apache/pdfbox/cos/ pdfbox/src/main/java/org/apache/pdfbox/rendering/ pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/

[tilman]

Author: tilman
Date: Sat May  3 06:22:04 2014
New Revision: 1592153

URL: http://svn.apache.org/r1592153
Log:
PDFBOX-2054: replace printStackTrace() and System.out.println() with logging as 
suggested by Hong-Thai Nguyen

Modified:
    
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java

Modified: 
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java?rev=1592153&r1=1592152&r2=1592153&view=diff
==============================================================================
--- 
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java
 (original)
+++ 
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java
 Sat May  3 06:22:04 2014
@@ -19,6 +19,8 @@
 package org.apache.fontbox.ttf;
 
 import java.io.IOException;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * This class is based on code from Apache Batik a subproject of Apache 
XMLGraphics. see
@@ -27,6 +29,11 @@ import java.io.IOException;
 public class GlyfSimpleDescript extends GlyfDescript
 {
 
+    /**
+     * Log instance.
+     */
+    private static final Log LOG = LogFactory.getLog(GlyfSimpleDescript.class);
+
     private int[] endPtsOfContours;
     private byte[] flags;
     private short[] xCoordinates;
@@ -197,7 +204,7 @@ public class GlyfSimpleDescript extends 
         }
         catch (ArrayIndexOutOfBoundsException e)
         {
-            System.out.println("error: array index out of bounds");
+            LOG.error("error: array index out of bounds", e);
         }
     }
 

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java?rev=1592153&r1=1592152&r2=1592153&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java 
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSString.java Sat 
May  3 06:22:04 2014
@@ -19,6 +19,8 @@ package org.apache.pdfbox.cos;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 import org.apache.pdfbox.encoding.PdfDocEncoding;
 import org.apache.pdfbox.persistence.util.COSHEXTable;
@@ -31,6 +33,12 @@ import org.apache.pdfbox.persistence.uti
  */
 public class COSString extends COSBase
 {
+
+    /**
+     * Log instance.
+     */
+    private static final Log LOG = LogFactory.getLog(COSString.class);
+
     /**
      * One of the open string tokens.
      */
@@ -140,7 +148,7 @@ public class COSString extends COSBase
         }
         catch (IOException ignore)
         {
-            ignore.printStackTrace();
+            LOG.error(ignore,ignore);
             // should never happen
         }
     }
@@ -160,7 +168,7 @@ public class COSString extends COSBase
         }
         catch (IOException ignore)
         {
-            ignore.printStackTrace();
+            LOG.error(ignore,ignore);
             // should never happen
         }
     }
@@ -320,7 +328,7 @@ public class COSString extends COSBase
         catch (IOException e)
         {
             // should never happen
-            e.printStackTrace();
+            LOG.error(e,e);
             retval = new String(getBytes());
         }
         this.str = retval;

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java?rev=1592153&r1=1592152&r2=1592153&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java 
(original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java 
Sat May  3 06:22:04 2014
@@ -333,7 +333,7 @@ public class PageDrawer extends PDFStrea
         }
         catch (IOException io)
         {
-            io.printStackTrace();
+            LOG.error (io, io);
         }
     }
 

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java?rev=1592153&r1=1592152&r2=1592153&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/pagedrawer/Invoke.java
 Sat May  3 06:22:04 2014
@@ -89,7 +89,6 @@ public final class Invoke extends Operat
             catch (Exception e)
             {
                 // TODO we probably shouldn't catch Exception, what errors are 
expected here?
-                e.printStackTrace();
                 LOG.error(e, e);
             }
         }